New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Logo GUIDs and replaced with Data URIs and div hidden with JS #132

Merged
merged 5 commits into from Aug 6, 2012

Conversation

@hikari-no-yume
Contributor

hikari-no-yume commented Jul 14, 2012

  • removed php_logo_guid()
  • removed php_egg_logo_guid()
  • removed php_real_logo_guid()
  • removed zend_logo_guid()
  • removed logo GUID handling
  • removed logo GUIDs from source
  • added logo data URIs instead for phpinfo()
  • added credits to phpinfo() page, but hidden by default
Removed Logo GUIDs and replaced with Data URIs and div hidden with JS
- removed php_logo_guid()
- removed php_egg_logo_guid()
- removed php_real_logo_guid()
- removed zend_logo_guid()
- removed logo GUID handling
- removed logo GUIDs from source
- added logo data URIs instead for phpinfo()
- added credits to phpinfo() page, but hidden by default
Show outdated Hide outdated ext/standard/info.c
@smalyshev

This comment has been minimized.

Show comment
Hide comment
@smalyshev

smalyshev Jul 14, 2012

Contributor

I like the idea, but I am a bit concerned on Javascript thing - it looks like it'd be impossible to see credits in a browser that doesn't have Javascript enabled.

Contributor

smalyshev commented Jul 14, 2012

I like the idea, but I am a bit concerned on Javascript thing - it looks like it'd be impossible to see credits in a browser that doesn't have Javascript enabled.

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Jul 14, 2012

Member

@smalyshev The credits are hidden using JS. So if JS is disabled the credits won't get hidden ;)

Member

nikic commented Jul 14, 2012

@smalyshev The credits are hidden using JS. So if JS is disabled the credits won't get hidden ;)

@hikari-no-yume

This comment has been minimized.

Show comment
Hide comment
@hikari-no-yume

hikari-no-yume Jul 14, 2012

Contributor

No, it's visible by default, it's just hidden by the JavaScript when the page loads. So if you have JS turned off, you can see it fine. If you have it turned on, you'll have to click the link to see it.

Edit: nikic beat me to it :)

Contributor

hikari-no-yume commented Jul 14, 2012

No, it's visible by default, it's just hidden by the JavaScript when the page loads. So if you have JS turned off, you can see it fine. If you have it turned on, you'll have to click the link to see it.

Edit: nikic beat me to it :)

@laruence

This comment has been minimized.

Show comment
Hide comment
@laruence

laruence Jul 15, 2012

Member

Hi:

  1. it's better use a local var hold the result of getElementById
  2. 'use strict' is not necessary here, since we only have less than 10 lines js codes
  3. seems we can only 'display' the credits, but can not 'hidden' it again.

thanks :)

Member

laruence commented Jul 15, 2012

Hi:

  1. it's better use a local var hold the result of getElementById
  2. 'use strict' is not necessary here, since we only have less than 10 lines js codes
  3. seems we can only 'display' the credits, but can not 'hidden' it again.

thanks :)

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Jul 15, 2012

Member

@laruence The use strict doesn't hurt anyone though ^^

Member

nikic commented Jul 15, 2012

@laruence The use strict doesn't hurt anyone though ^^

@hikari-no-yume

This comment has been minimized.

Show comment
Hide comment
@hikari-no-yume

hikari-no-yume Jul 15, 2012

Contributor

If it matters so much I'll clear up the code a little, but 'use strict' is best practise.

Contributor

hikari-no-yume commented Jul 15, 2012

If it matters so much I'll clear up the code a little, but 'use strict' is best practise.

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Jul 16, 2012

Comment on behalf of laruence at php.net:

closed

php-pulls commented Jul 16, 2012

Comment on behalf of laruence at php.net:

closed

@php-pulls php-pulls closed this Jul 16, 2012

@laruence

This comment has been minimized.

Show comment
Hide comment
@laruence

laruence Jul 16, 2012

Member

damned, I am testing the pull request list bug, closed this by accident...

Member

laruence commented Jul 16, 2012

damned, I am testing the pull request list bug, closed this by accident...

@bjori bjori reopened this Jul 16, 2012

@laruence

This comment has been minimized.

Show comment
Hide comment
@laruence

laruence Jul 16, 2012

Member

@bjori thanks :)

Member

laruence commented Jul 16, 2012

@bjori thanks :)

Show outdated Hide outdated ext/standard/info.c
@MartinZottmann

This comment has been minimized.

Show comment
Hide comment
@MartinZottmann

MartinZottmann Jul 26, 2012

+1 for this request

MartinZottmann commented Jul 26, 2012

+1 for this request

@pilif

This comment has been minimized.

Show comment
Hide comment
@pilif

pilif Jul 28, 2012

Contributor

You could use window.addEventListener for compatibility with pages that embed the phpinfo() output.

This of course would produce very broken HTML as the phpinfo() output contains a full html page including the root element and a doctype and pretty nonspecific CSS which would certainly clash with the embedding pages.

For these reasons, I would guess that enbedding via an iframe makes more sense anyways - but who knows what people are doing.

Contributor

pilif commented Jul 28, 2012

You could use window.addEventListener for compatibility with pages that embed the phpinfo() output.

This of course would produce very broken HTML as the phpinfo() output contains a full html page including the root element and a doctype and pretty nonspecific CSS which would certainly clash with the embedding pages.

For these reasons, I would guess that enbedding via an iframe makes more sense anyways - but who knows what people are doing.

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Aug 6, 2012

Comment on behalf of stas at php.net:

merged

php-pulls commented Aug 6, 2012

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Aug 6, 2012

@php-pulls php-pulls merged commit b1a997e into php:master Aug 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment