Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Logo GUIDs and replaced with Data URIs and div hidden with JS #132

Merged
merged 5 commits into from Aug 6, 2012

Conversation

hikari-no-yume
Copy link
Contributor

  • removed php_logo_guid()
  • removed php_egg_logo_guid()
  • removed php_real_logo_guid()
  • removed zend_logo_guid()
  • removed logo GUID handling
  • removed logo GUIDs from source
  • added logo data URIs instead for phpinfo()
  • added credits to phpinfo() page, but hidden by default

- removed php_logo_guid()
- removed php_egg_logo_guid()
- removed php_real_logo_guid()
- removed zend_logo_guid()
- removed logo GUID handling
- removed logo GUIDs from source
- added logo data URIs instead for phpinfo()
- added credits to phpinfo() page, but hidden by default
php_info_print(" document.getElementById('credits').style.display = 'block';\n");
php_info_print(" document.getElementById('revealcredits').style.display = 'none';\n");
php_info_print(" };\n");
php_info_print(" };\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small misalign :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@smalyshev
Copy link
Contributor

I like the idea, but I am a bit concerned on Javascript thing - it looks like it'd be impossible to see credits in a browser that doesn't have Javascript enabled.

@nikic
Copy link
Member

nikic commented Jul 14, 2012

@smalyshev The credits are hidden using JS. So if JS is disabled the credits won't get hidden ;)

@hikari-no-yume
Copy link
Contributor Author

No, it's visible by default, it's just hidden by the JavaScript when the page loads. So if you have JS turned off, you can see it fine. If you have it turned on, you'll have to click the link to see it.

Edit: nikic beat me to it :)

@laruence
Copy link
Member

Hi:

  1. it's better use a local var hold the result of getElementById
  2. 'use strict' is not necessary here, since we only have less than 10 lines js codes
  3. seems we can only 'display' the credits, but can not 'hidden' it again.

thanks :)

@nikic
Copy link
Member

nikic commented Jul 15, 2012

@laruence The use strict doesn't hurt anyone though ^^

@hikari-no-yume
Copy link
Contributor Author

If it matters so much I'll clear up the code a little, but 'use strict' is best practise.

@php-pulls
Copy link

Comment on behalf of laruence at php.net:

closed

@php-pulls php-pulls closed this Jul 16, 2012
@laruence
Copy link
Member

damned, I am testing the pull request list bug, closed this by accident...

@bjori bjori reopened this Jul 16, 2012
@laruence
Copy link
Member

@bjori thanks :)

php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000\">");
php_info_print("<script>(function () {\n");
php_info_print(" 'use strict';\n");
php_info_print(" window.onload = function () {\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause strange behavior if somebody is embedding the phpinfo() page in a page already overwriting window.onload? People are embedding phpinfo() in installers or configuration areas for different applications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldn't be including a full HTML page, that's bound to break
things anyway. They should be using an iframe or a popup. I feel no
sympathy for them if they're doing that, things can break.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.onload should just be onload [edited], since window is a reference to the global object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, what? If you replace window.onload with window you'd overwrite the global scope with said function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to be more specific (and hence verbose). I always use, e.g.,
window.onload, window.WebSocket, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpinfo and phpcredits aren't the same thing.

Please give me an actual example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TazeTSchnitzel I think your Facebook just went wild ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it did. Last time I trust them with my contact list.

This is very irritating, I apologise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under normal circumstances I'd mock you for having a Facebook account in
the first place. But o think you've already seen the error of your ways ;)
On Aug 11, 2012 2:51 PM, "Andrew Faulds" notifications@github.com wrote:

In ext/standard/info.c:

    php_info_print_hr();
  •   php_info_print("<h1><a href=\"");
    
  •   php_info_print_request_uri(TSRMLS_C);
    
  •   php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000\">");
    
  •   php_info_print("<script>(function () {\n");
    
  •   php_info_print("    'use strict';\n");
    
  •   php_info_print("    window.onload = function () {\n");
    

Yes it did. Last time I trust them with my contact list. This is very
irritating, I apologise.
-- Sent from Samsung Mobile Andrew Faulds http://ajf.me/ nikic <
notifications@github.com> hat geschrieben: In ext/standard/info.c:
php_info_print_hr(); - php_info_print("

<a href=""); -
php_info_print_request_uri(TSRMLS_C); -
php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000">"); +
php_info_print("<script>(function () {\n"); + php_info_print(" 'use
strict';\n"); + php_info_print(" window.onload = function () {\n");
@TazeTSchnitzel https://github.com/TazeTSchnitzel I think your
Facebook just went wild ;) — Reply to this email directly or view it on
GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/132/files#r1357361.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought rejoining Facebook was a good thing.

I was sadly mistaken ;)

@MartinZottmann
Copy link

+1 for this request

@pilif
Copy link
Contributor

pilif commented Jul 28, 2012

You could use window.addEventListener for compatibility with pages that embed the phpinfo() output.

This of course would produce very broken HTML as the phpinfo() output contains a full html page including the root element and a doctype and pretty nonspecific CSS which would certainly clash with the embedding pages.

For these reasons, I would guess that enbedding via an iframe makes more sense anyways - but who knows what people are doing.

@php-pulls
Copy link

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Aug 6, 2012
@php-pulls php-pulls merged commit b1a997e into php:master Aug 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet