Removed Logo GUIDs and replaced with Data URIs and div hidden with JS

[hikari-no-yume]

• removed php_logo_guid()
• removed php_egg_logo_guid()
• removed php_real_logo_guid()
• removed zend_logo_guid()
• removed logo GUID handling
• removed logo GUIDs from source
• added logo data URIs instead for phpinfo()
• added credits to phpinfo() page, but hidden by default

[nikic]

A small misalign :)

[hikari-no-yume]

fixed

[smalyshev]

I like the idea, but I am a bit concerned on Javascript thing - it looks like it'd be impossible to see credits in a browser that doesn't have Javascript enabled.

[nikic]

@smalyshev The credits are hidden using JS. So if JS is disabled the credits won't get hidden ;)

[hikari-no-yume]

No, it's visible by default, it's just hidden by the JavaScript when the page loads. So if you have JS turned off, you can see it fine. If you have it turned on, you'll have to click the link to see it.

Edit: nikic beat me to it :)

[laruence]

Hi:

1. it's better use a local var hold the result of getElementById
2. 'use strict' is not necessary here, since we only have less than 10 lines js codes
3. seems we can only 'display' the credits, but can not 'hidden' it again.

thanks :)

[nikic]

@laruence The use strict doesn't hurt anyone though ^^

[hikari-no-yume]

If it matters so much I'll clear up the code a little, but 'use strict' is best practise.

[php-pulls]

Comment on behalf of laruence at php.net:

closed

[laruence]

damned, I am testing the pull request list bug, closed this by accident...

[laruence]

@bjori thanks :)

[johannes]

Won't this cause strange behavior if somebody is embedding the phpinfo() page in a page already overwriting window.onload? People are embedding phpinfo() in installers or configuration areas for different applications.

[hikari-no-yume]

They shouldn't be including a full HTML page, that's bound to break
things anyway. They should be using an iframe or a popup. I feel no
sympathy for them if they're doing that, things can break.

[rvanvelzen]

window.onload should just be onload [edited], since window is a reference to the global object.

[nikic]

Huh, what? If you replace window.onload with window you'd overwrite the global scope with said function.

[hikari-no-yume]

I prefer to be more specific (and hence verbose). I always use, e.g.,
window.onload, window.WebSocket, etc.

[hikari-no-yume]

phpinfo and phpcredits aren't the same thing.

Please give me an actual example.

[nikic]

@TazeTSchnitzel I think your Facebook just went wild ;)

[hikari-no-yume]

Yes it did. Last time I trust them with my contact list.

This is very irritating, I apologise.

[lt]

Under normal circumstances I'd mock you for having a Facebook account in
the first place. But o think you've already seen the error of your ways ;)
On Aug 11, 2012 2:51 PM, "Andrew Faulds" notifications@github.com wrote:

In ext/standard/info.c:

    php_info_print_hr();

•   php_info_print("<h1><a href=\"");
  

•   php_info_print_request_uri(TSRMLS_C);
  

•   php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000\">");
  

•   php_info_print("<script>(function () {\n");
  

•   php_info_print("    'use strict';\n");
  

•   php_info_print("    window.onload = function () {\n");
  

Yes it did. Last time I trust them with my contact list. This is very
irritating, I apologise.
-- Sent from Samsung Mobile Andrew Faulds http://ajf.me/ nikic <
notifications@github.com> hat geschrieben: In ext/standard/info.c:
php_info_print_hr(); - php_info_print("

<a href=""); -
php_info_print_request_uri(TSRMLS_C); -
php_info_print("?=PHPB8B5F2A0-3C92-11d3-A3A9-4C7B08C10000">"); +
php_info_print("<script>(function () {\n"); + php_info_print(" 'use
strict';\n"); + php_info_print(" window.onload = function () {\n");
@TazeTSchnitzel https://github.com/TazeTSchnitzel I think your
Facebook just went wild ;) — Reply to this email directly or view it on
GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/132/files#r1357361.

[hikari-no-yume]

I thought rejoining Facebook was a good thing.

I was sadly mistaken ;)

[ghost]

+1 for this request

[pilif]

You could use window.addEventListener for compatibility with pages that embed the phpinfo() output.

This of course would produce very broken HTML as the phpinfo() output contains a full html page including the root element and a doctype and pretty nonspecific CSS which would certainly clash with the embedding pages.

For these reasons, I would guess that enbedding via an iframe makes more sense anyways - but who knows what people are doing.

[php-pulls]

Comment on behalf of stas at php.net:

merged