New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*[Sessions]: Now session is accessible if process is ran by root. #1360

Merged
merged 3 commits into from Jan 6, 2017

Conversation

5 participants
@EvgeniySpinov
Contributor

EvgeniySpinov commented Jun 24, 2015

Fixing bug: https://bugs.php.net/bug.php?id=69582

Use case: session is initiated by Apache with non-root permissions. Later on, session could be accessed by backend process, which runs under root, but needs to communicate with same session data as Apache process.

Didn't work before this commit: session file is owned by non-root, process owner != file owner, so this triggered file handle closure.

@laruence

This comment has been minimized.

Show comment
Hide comment
@laruence

laruence Jun 24, 2015

Member

please leave this one, and close others. we can merge it downwards if it is necessary.

Member

laruence commented Jun 24, 2015

please leave this one, and close others. we can merge it downwards if it is necessary.

@laruence laruence added the Bugfix label Jun 24, 2015

@EvgeniySpinov

This comment has been minimized.

Show comment
Hide comment
@EvgeniySpinov

EvgeniySpinov Jun 24, 2015

Contributor

Done. Weird, that CI build has failed for this Pull Request, while successfully passed for one of the closed ones.

Contributor

EvgeniySpinov commented Jun 24, 2015

Done. Weird, that CI build has failed for this Pull Request, while successfully passed for one of the closed ones.

Show outdated Hide outdated ext/session/mod_files.c Outdated
@EvgeniySpinov

This comment has been minimized.

Show comment
Hide comment
@EvgeniySpinov

EvgeniySpinov Jun 28, 2015

Contributor

Done that.

Contributor

EvgeniySpinov commented Jun 28, 2015

Done that.

php-pulls pushed a commit that referenced this pull request Jan 6, 2017

Merge branch 'pull-request/1360' into PHP-7.0
* pull-request/1360:
  Fixed bug #69582 session not readable by root in CLI
  news entry for PR #1360

@php-pulls php-pulls merged commit 650e073 into php:master Jan 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 6, 2017

Member

Thanks :)

Member

krakjoe commented Jan 6, 2017

Thanks :)

@EvgeniySpinov

This comment has been minimized.

Show comment
Hide comment
@EvgeniySpinov

EvgeniySpinov Jan 6, 2017

Contributor

@krakjoe Thanks for merging. Is there are any plans for merging it downstream, like at least 5.6?

Contributor

EvgeniySpinov commented Jan 6, 2017

@krakjoe Thanks for merging. Is there are any plans for merging it downstream, like at least 5.6?

@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 6, 2017

Member

It is present in all branches in supported release cycle. 5.6 is in security fix only cycle and so should not be having fixes like this merged, sorry about that.

Member

krakjoe commented Jan 6, 2017

It is present in all branches in supported release cycle. 5.6 is in security fix only cycle and so should not be having fixes like this merged, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment