From 3a6353830c400c94868f14e496eadd45fb58951f Mon Sep 17 00:00:00 2001 From: Michael Orlitzky Date: Fri, 15 Mar 2024 12:52:29 -0400 Subject: [PATCH] ext/gd/config.m4: don't forget GDLIB_CFLAGS in feature tests In commit 85e5635a, a feature test for the various libgd image formats was added. That test however erroneously omits the GDLIB_CFLAGS (from pkg-config) during compilation. This can lead to build failures and therefore false negatives from the test. Here, we add $GDLIB_CFLAGS to $CFLAGS for the duration of the test. Closes GH-12019 --- ext/gd/config.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ext/gd/config.m4 b/ext/gd/config.m4 index b13b942a3c74d..d9c6d4f6ee0c2 100644 --- a/ext/gd/config.m4 +++ b/ext/gd/config.m4 @@ -150,6 +150,8 @@ dnl or run test insufficient. AC_DEFUN([PHP_GD_CHECK_FORMAT],[ old_LIBS="${LIBS}" LIBS="${LIBS} ${GD_SHARED_LIBADD}" + old_CFLAGS="${CFLAGS}" + CFLAGS="${CFLAGS} ${GDLIB_CFLAGS}" AC_MSG_CHECKING([for working gdImageCreateFrom$1 in libgd]) AC_LANG_PUSH([C]) AC_RUN_IFELSE([AC_LANG_SOURCE([ @@ -180,6 +182,7 @@ int main(int argc, char** argv) { AC_MSG_RESULT([no]) ]) AC_LANG_POP([C]) + CFLAGS="${old_CFLAGS}" LIBS="${old_LIBS}" ])