New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #70103: ZipArchive::addGlob ignores remove_all_path option #1430

Merged
merged 1 commit into from Jan 6, 2017

Conversation

5 participants
@cmb69
Contributor

cmb69 commented Jul 20, 2015

When the remove_all_path option is set, but no add_path option, remove_all_path
is simply ignored. This patch fixes this.

The PR is against master, but this should be merged to PHP 5.6 as well.

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Jul 20, 2015

Contributor

Can anybody explain this test failure? Doesn't make any sense to me.

Contributor

cmb69 commented Jul 20, 2015

Can anybody explain this test failure? Doesn't make any sense to me.

@smalyshev smalyshev added the Bugfix label Jul 25, 2015

Fix #70103: ZipArchive::addGlob ignores remove_all_path option
When the remove_all_path option is set, but no add_path option, remove_all_path
is simply ignored. This patch fixes this.
@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Aug 13, 2015

Contributor

Rebased onto current master to trigger the Travis checks again.

Contributor

cmb69 commented Aug 13, 2015

Rebased onto current master to trigger the Travis checks again.

@weltling

This comment has been minimized.

Show comment
Hide comment
@weltling

weltling Aug 19, 2015

Contributor

Manual test with master looks ok.

Thanks.

Contributor

weltling commented Aug 19, 2015

Manual test with master looks ok.

Thanks.

php-pulls pushed a commit that referenced this pull request Jan 6, 2017

Merge branch 'PHP-7.0' into PHP-7.1
* PHP-7.0:
  Fix #70103: ZipArchive::addGlob ignores remove_all_path option
  news entry for PR #1430

@php-pulls php-pulls merged commit c36ce04 into php:master Jan 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 6, 2017

Member

Thanks :)

Member

krakjoe commented Jan 6, 2017

Thanks :)

php-pulls pushed a commit that referenced this pull request Jan 6, 2017

Merge branch 'PHP-7.1'
* PHP-7.1:
  Fix #70103: ZipArchive::addGlob ignores remove_all_path option
  news entry for PR #1430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment