Use zend_execute_internal always to call internal functions #178

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

smalyshev commented Aug 27, 2012

This patch restores the use of zend_execute_internal to call internal functions when they are called from another internal function via zend_call_function. This will allow modules to intercept it more efficiently. Unfortunately, this also requires slight API change and may require to fix the overriding function code since new way of calling was added. If the function does anything with execute data, it also would have to consider that some of these data can be wrong for current function if fci parameter is set and take it as overriding authority.

smalyshev added some commits Jul 22, 2012

use zend_execute_internal if set on internal-internal calls
This will allow modules that override zend_execute_internal to intercept
all internal function calls, not just user-internal calls.

This pull request fails (merged cd5b933 into cec1786).

Comment on behalf of stas at php.net:

merged

@php-pulls php-pulls closed this Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment