Bug #62479 Fix bug where spaces in passwords would fail #199

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
6 participants
@willfitch
Contributor

willfitch commented Sep 20, 2012

Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018

Bug #62479 Fix bug where spaces in passwords would fail
Change-Id: I53679937d69b0a8897961900ebf33d197b8ce018
@lstrojny

This comment has been minimized.

Show comment Hide comment
@lstrojny

lstrojny Sep 21, 2012

Contributor

Thanks! We need a test for that.

Contributor

lstrojny commented Sep 21, 2012

Thanks! We need a test for that.

@willfitch

This comment has been minimized.

Show comment Hide comment
@willfitch

willfitch Sep 28, 2012

Contributor

Test added @lstrojny

Contributor

willfitch commented Sep 28, 2012

Test added @lstrojny

@dsp

This comment has been minimized.

Show comment Hide comment
@dsp

dsp Oct 30, 2012

Member

Maybe @iliaal want to have a look,he is the official maintainer.

Member

dsp commented Oct 30, 2012

Maybe @iliaal want to have a look,he is the official maintainer.

@iliaal

This comment has been minimized.

Show comment Hide comment
@iliaal

iliaal Oct 31, 2012

Contributor

I think the patch inside http://ilia.ws/patch/pdo.txt maybe better, as it also accounts for the possibility of the password containing \ character.

Contributor

iliaal commented Oct 31, 2012

I think the patch inside http://ilia.ws/patch/pdo.txt maybe better, as it also accounts for the possibility of the password containing \ character.

@lstrojny

This comment has been minimized.

Show comment Hide comment
@lstrojny

lstrojny Jan 6, 2013

Contributor

@iliaal will you merge your patch and close this PR?

Contributor

lstrojny commented Jan 6, 2013

@iliaal will you merge your patch and close this PR?

@lstrojny

This comment has been minimized.

Show comment Hide comment
@lstrojny

lstrojny Jan 14, 2013

Contributor

@iliaal ping

Contributor

lstrojny commented Jan 14, 2013

@iliaal ping

@smalyshev

This comment has been minimized.

Show comment Hide comment
@smalyshev

smalyshev Jul 22, 2013

Contributor

@willfitch any news?

Contributor

smalyshev commented Jul 22, 2013

@willfitch any news?

@php-pulls

This comment has been minimized.

Show comment Hide comment
@php-pulls

php-pulls Aug 5, 2013

Comment on behalf of stas at php.net:

Looks like this one is abandoned. Since Ilia thinks different patch is better, closing this one.

Comment on behalf of stas at php.net:

Looks like this one is abandoned. Since Ilia thinks different patch is better, closing this one.

@php-pulls php-pulls closed this Aug 5, 2013

@willfitch

This comment has been minimized.

Show comment Hide comment
@willfitch

willfitch Oct 30, 2013

Contributor

Where did this go? Just trying to see if @iliaal's patch made it in.

Contributor

willfitch commented Oct 30, 2013

Where did this go? Just trying to see if @iliaal's patch made it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment