Fix for bug #54431 #2015

Closed
wants to merge 1 commit into
from

Conversation

2 participants
@vhuk
Contributor

vhuk commented Jul 21, 2016

New version enables encryption of the datastream instead of control channel to avoid issues describe in bugs #41021, #54431. Control channel is already encrypted earlier hence re-enabling encryption on it will fail.

@nikic nikic added the Bugfix label Jul 23, 2016

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Jul 23, 2016

Member

Merged as 65abdb5 into PHP 5.6 and up. Thanks!

It would've been nice to have a test for this, but it doesn't look like we currently have any infrastructure for testing ftp:// streams. The server.inc in ext/ftp is pretty tailored to the ext/ftp tests and doesn't really work with ftp://.

Member

nikic commented Jul 23, 2016

Merged as 65abdb5 into PHP 5.6 and up. Thanks!

It would've been nice to have a test for this, but it doesn't look like we currently have any infrastructure for testing ftp:// streams. The server.inc in ext/ftp is pretty tailored to the ext/ftp tests and doesn't really work with ftp://.

@nikic nikic closed this Jul 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment