Skip to content

Make bug70417.phpt less flaky #20287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make bug70417.phpt less flaky #20287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions ext/phar/tests/tar/bug70417.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,32 +3,17 @@ Bug #70417 (PharData::compress() doesn't close temp file)
--EXTENSIONS--
phar
zlib
--SKIPIF--
<?php

exec('lsof -p ' . getmypid(), $out, $status);
if ($status !== 0) {
die("skip lsof(8) not available");
}
if (!str_starts_with($out[0], 'COMMAND')) {
die("skip Might be a different lsof");
}
?>
--FILE--
<?php
function countOpenFiles() {
exec('lsof -p ' . escapeshellarg(getmypid()) . ' 2> /dev/null', $out); // Note: valgrind can produce false positives for /usr/bin/lsof
return count($out);
}
$filename = __DIR__ . '/bug70417.tar';
@unlink("$filename.gz");
$openFiles1 = countOpenFiles();
$resBefore = count(get_resources());
$arch = new PharData($filename);
$arch->addFromString('foo', 'bar');
$arch->compress(Phar::GZ);
unset($arch);
$openFiles2 = countOpenFiles();
var_dump($openFiles1 === $openFiles2);
$resAfter = count(get_resources());
var_dump($resBefore === $resAfter);
?>
--CLEAN--
<?php
Expand Down
Loading