-
Notifications
You must be signed in to change notification settings - Fork 8k
Verify bundled sources using CI - boost.context & uriparser #20438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5a94e72 to
623876d
Compare
afa7639 to
39a8c6f
Compare
39a8c6f to
0a2d4f7
Compare
…s on Windows vs. linux
|
I love the concept, thanks! Can you show an example failure?
I find it the opposite way: in its current form, I find it very difficult to understand now. |
Thank you ❤ Using mvorisek@738c667 commit a failure is simulated - see CI results in https://github.com/mvorisek/php-src/actions/runs/19343856007/job/55338921670.
Why, how can it be done better? Maintaining the yml file by hand would not be practical as names/paths are copied in several places. Adding a new bundle is easy - add 1 line to https://github.com/php/php-src/blob/94cdb07789/.github/scripts/download-bundled/make-workflow-file.php#L8-L12. The script also generates partly the download scripts with canonical temporary directory names. In case you would do any manual change to the yml by mistake, the CI at https://github.com/php/php-src/blob/94cdb07789/.github/actions/verify-generated-files/action.yml#L16 will warn you about. |
| # use the repo root directory as "--git-dir" | ||
| cd "$(dirname "$0")/../.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important as the original cd "$(dirname "$0")/../../$1" did not detected any changes in case of the checked directory was containing .git.
Example: git clone https://github.com/derickr/timelib.git ext/date/lib
part of #19802
assert #20375 and #20437 using CI
The workflow YML file is generated to make adding/maintaining it easier.