Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug #52958 :: Segfault in PDO_OCI on cleanup after running a long testsuite. #219

Closed
wants to merge 1 commit into from

2 participants

@hswong3i

Please refer to https://bugs.php.net/bug.php?id=52958 for more information.

P.S. May someone help to contribute the php-level test case for this issue?

Sorry that since this bug will ALWAYS hit during installation when develop with Drupal 7.x pdo_oci driver, but very hard to reproduce its trigger with simple test cases...

Hope someone can give a hand for it ;-)

@php-pulls
Collaborator

Comment on behalf of lstrojny at php.net:

Fixed in 5.4, 5.5 and master.

@php-pulls php-pulls closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 2 deletions.
  1. +4 −2 ext/pdo_oci/oci_driver.c
View
6 ext/pdo_oci/oci_driver.c
@@ -227,8 +227,10 @@ static int oci_handle_closer(pdo_dbh_t *dbh TSRMLS_DC) /* {{{ */
H->server = NULL;
}
- OCIHandleFree(H->err, OCI_HTYPE_ERROR);
- H->err = NULL;
+ if (H->err) {
+ OCIHandleFree(H->err, OCI_HTYPE_ERROR);
+ H->err = NULL;
+ }
if (H->charset && H->env) {
OCIHandleFree(H->env, OCI_HTYPE_ENV);
Something went wrong with that request. Please try again.