New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug #73462 - Persistent connections don't set $connect_errno #2193

Closed
wants to merge 2 commits into
base: PHP-5.6
from

Conversation

2 participants
@darkain
Contributor

darkain commented Nov 7, 2016

Persistent connections skipped resetting $connect_error and $connect_errno values
This adds the "clear error" line to persistent connections for consistency

darkain added some commits Nov 7, 2016

Fix Bug #73462 - Persistent connections don't set $connect_errno
Persistent connections skipped resetting $connect_error and $connect_errno values
This adds the "clear error" line to persistent connections for consistency
@darkain

This comment has been minimized.

Show comment
Hide comment
@darkain

darkain Nov 8, 2016

Contributor

The failed Travis CI test is in unrelated code, specifically the FTP extension because a TCP port was already in use on the automated testing server. Not sure if there is an easy way to just re-run the test to show it is actually passing, or mark the failed test as irrelevant to the pull request here?

Contributor

darkain commented Nov 8, 2016

The failed Travis CI test is in unrelated code, specifically the FTP extension because a TCP port was already in use on the automated testing server. Not sure if there is an easy way to just re-run the test to show it is actually passing, or mark the failed test as irrelevant to the pull request here?

@pmmaga

This comment has been minimized.

Show comment
Hide comment
@pmmaga

pmmaga Nov 8, 2016

Contributor

You can squash your commits which should also trigger a new run

Contributor

pmmaga commented Nov 8, 2016

You can squash your commits which should also trigger a new run

@darkain darkain closed this Nov 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment