New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "register_globals" support codes from php/php_binary serializer #2233

Merged
merged 1 commit into from Dec 20, 2016

Conversation

3 participants
@yohgaki
Contributor

yohgaki commented Dec 7, 2016

This patch removes "register_globals" support codes from php/php_binary serializer.
As a result, users may use PS_UNDEF_MAKER(=!) char for session variable name.

This patch is a code cleanup. However, there could be compatibility issue when user mixing old PHP (less than PHP 5.4.0) that supports "register_globals" (i.e. Variables that are registered by session_register()) When session_register()ed variables are undefined, it results in error. Since session_register() is removed in PHP 5.4.0, PHP 5.4.0 or later has no issues.

If there is no comment, I'll merge this in a few days.

Yasuo Ohgaki
Remove "register_globals" support codes from php/php_binary serialize…
…rs. As a result, users may use PS_UNDEF_MAKER(=!) char for session variable name.
@KalleZ

This comment has been minimized.

Contributor

KalleZ commented Dec 7, 2016

I removed register_globals back then and it seems like an oversight on my part, so go ahead and commit this :)

@yohgaki

This comment has been minimized.

Contributor

yohgaki commented Dec 7, 2016

@KalleZ
Although I don't think it's a best practice mixing PHP versions and share the same session database, it is possible. So I think keeping them a while is good, but we don't need them anymore :)
I'll merge this in a few days.

@php-pulls php-pulls merged commit db30407 into php:master Dec 20, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment