If getrandom syscall is unavailable (ENOSYS), try to fallback on /dev/urandom #2385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff without WS changes: b2e7ce4?w=1 |
|
Merged via 5135828, thanks! I've changed the The control flow in this function is becoming complicated, should probably be split up. |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Feb 23, 2017
backport of php upstream patch fix getrandom() call for images, deployed on kernel < 3.17 php/php-src#2385
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Feb 23, 2017
backport of php upstream patch fix getrandom() call for images, deployed on kernel < 3.17 php/php-src#2385
vakartel
added a commit
to vakartel/aports
that referenced
this pull request
Feb 23, 2017
backport of php upstream patch fix getrandom() call for images, deployed on kernel < 3.17 php/php-src#2385
|
👍 Confirmed this fixed a bug for us on 7.1.2 -> 7.1.3. |
|
Specifically, |
glensc
pushed a commit
to glensc/php-alpine
that referenced
this pull request
Nov 10, 2019
backport of php upstream patch fix getrandom() call for images, deployed on kernel < 3.17 php/php-src#2385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getrandom() was introduced in version 3.17 of the Linux kernel.
The php package may be deployed on 3.10 kernel, try to be robust and fallback if we failed to use getrandom()
The "faulty" commit is 14c72cc