Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/filter support for validating MAC addresses. #247

Closed
wants to merge 3 commits into from

Conversation

@mj
Copy link
Contributor

commented Dec 25, 2012

This PR adds support to ext/filter to validate MAC addresses. It partially implements the feature request from bug #49180.

@lstrojny

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2012

Looks good!

@nikic

This comment has been minimized.

Copy link
Member

commented Dec 28, 2012

I probably misunderstood something, but why is this using memchr everywhere? With the last param being 1, isn't it equivalent to just doing a character comparison? Especially as you are not using the returned pointer.

@mj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2012

nikic, the memchr usage was a leftover and I have now removed it. Thanks for noticing!

@lstrojny

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

I think we need an RFC for that anywy. @nikic what do you think?

@nikic

This comment has been minimized.

Copy link
Member

commented Dec 29, 2012

I think an RFC is too much for this small addition, but it would be nice to at least bring this up on internals ;)

@lstrojny

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

Alright, @mj could you bring that up on Internals with something like "if no one objects it’s gonna be merged in a week".

@narfbg

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2012

A flag for specifying the valid format would be useful.

@mj

This comment has been minimized.

Copy link
Contributor Author

commented Dec 31, 2012

@narfbg: Good point, I'll look into it.

@lstrojny: I'll start a thread on internals this week.

@narfbg

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2013

Also, a no-delimiter format might also be useful. :)

@lstrojny

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2013

@mj as you said, you have anough karma. Go ahead. But please don't forget to squash the commits first.

@narfbg

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2013

Wouldn't the separator characters and/or formats be better off as flags?

@lstrojny

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2013

ping @mj

@mj

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2013

I'm pretty busy at the moment but will look into it ASAP.

@mj

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2013

Has been merged.

@mj mj closed this Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.