New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of FPM tests #3275

Merged
merged 1 commit into from Jun 12, 2018

Conversation

2 participants
@bukka
Copy link
Member

bukka commented Jun 7, 2018

This is a complete rewrite of the FPM tests to make them using a Tester instance that handle all the main logic and allow reusing it between tests. It simplifies the actual phpt files and allows some testing some advanced issues. It is prerequisite for the logger refactoring.

In addition it fixes the currently failing tests and changes the naming so it's a bit more logical.

The code was developed in fpmi and ported to fpm. This PR contains all tests for 7.1 and there will be 2 more tests added for 7.2 and master (new functionality in 7.2...)

@bukka bukka force-pushed the bukka:fpm_tests branch from fff7171 to 98b2ae8 Jun 12, 2018

@bukka bukka force-pushed the bukka:fpm_tests branch from 98b2ae8 to ea592e6 Jun 12, 2018

@php-pulls php-pulls merged commit ea592e6 into php:PHP-7.1 Jun 12, 2018

0 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment