Rewrite of FPM tests - #3275
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of the FPM tests to make them using a Tester instance that handle all the main logic and allow reusing it between tests. It simplifies the actual
phptfiles and allows some testing some advanced issues. It is prerequisite for the logger refactoring.In addition it fixes the currently failing tests and changes the naming so it's a bit more logical.
The code was developed in fpmi and ported to fpm. This PR contains all tests for 7.1 and there will be 2 more tests added for 7.2 and master (new functionality in 7.2...)