Rename enable-maintainer-zts to enable-zts #3974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a "maintainer" feature, this commits renames --enable-maintainer-zts to --enable-zts in the autotools build, and related documentation
Member
|
I'm fine with this minor change. The annoying thing with this option, not related to this change, is the lack of --disable-zts (as it will be ignored when apache is in thread mode... ), as whatever how apache is currently configure, I may want to build NTS or ZTS php, or both.... |
Member
|
What about in combination with |
Member
|
@petk I don't think it makes sense to add it to |
Member
Author
|
Merged as 161adff |
Contributor
|
Can we keep |
Member
Author
|
I think it's not necessary as this was merged into PHP 8, more than a year
to update those CI platforms is long enough.
Cheers
Joe
…On Sat, 23 Mar 2019, 14:39 Pedro Magalhães, ***@***.***> wrote:
Can we keep --enable-maintainer-zts as an alias for BC? This will
silently (with a warning) start building NTS on some CI pipelines.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3974 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACIe6teasRGOlgNaUVhDgcy7EHbK4dvaks5vZi6sgaJpZM4cDIlQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's about time we admitted this isn't a "maintainer" or experimental option, but a core part of PHP ...