Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union types #4838

Closed
wants to merge 48 commits into from
Closed

Union types #4838

wants to merge 48 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 21, 2019

Implementation for union types RFC.

@nikic nikic added the RFC label Oct 21, 2019
Copy link
Contributor

@Ocramius Ocramius left a comment

Only had time to go through the tests: huge work, nice!

@nikic nikic force-pushed the union-types branch 5 times, most recently from a68c5eb to 471931e Compare Oct 25, 2019
azjezz
azjezz approved these changes Oct 25, 2019
Copy link

@azjezz azjezz left a comment

Awesome work, thanks @nikic ❤️

@strongholdmedia
Copy link
Contributor

@strongholdmedia strongholdmedia commented Jul 8, 2020

My only question in retrospect is why wait for PHP 8?
I mean, @nikic stated no backwards-incompatible changes.

@azjezz
Copy link

@azjezz azjezz commented Jul 8, 2020

@strongholdmedia because 7.4 went feature freez around a year ago 😄 ( https://externals.io/message/106249 )

@strongholdmedia
Copy link
Contributor

@strongholdmedia strongholdmedia commented Jul 8, 2020

Sure, I do know that. :)
I suppose that means there will be no PHP 7.5 then.
Thanks for the implicit heads up. :)

@azjezz
Copy link

@azjezz azjezz commented Jul 8, 2020

Yes, there's no 7.5 :)

@strongholdmedia
Copy link
Contributor

@strongholdmedia strongholdmedia commented Jul 8, 2020

The uttermost shame is that I am long since subscribed to the internals list, but I couldn't get myself to wade through the nonsense of the attached .eml forest that is a PITA to view :/

Perhaps it is just time to switch to the regular format from the digest stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants