Check that all "required" classes can be preloaded #4997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
reviewed
Dec 10, 2019
| @@ -12,5 +12,4 @@ opcache.preload={PWD}/preload_undef_const.inc | |||
| var_dump(class_exists('Foo')); | |||
| ?> | |||
| --EXPECTF-- | |||
| Warning: Can't preload class Foo with unresolved initializer for constant A in %spreload_undef_const.inc on line 2 | |||
| bool(false) | |||
| Fatal error: Undefined class constant 'self::DOES_NOT_EXIST' in Unknown on line 0 | |||
There was a problem hiding this comment.
May be add a hint to try preloading through opcache_compile_file()?
dstogov
reviewed
Dec 10, 2019
| @@ -13,6 +13,6 @@ var_dump(trait_exists('T')); | |||
| var_dump(class_exists('Foo')); | |||
| ?> | |||
| --EXPECTF-- | |||
| Warning: Can't preload class Foo with unresolved initializer for constant C in %spreload_undef_const_2.inc on line 8 | |||
| Warning: Use of undefined constant UNDEF - assumed 'UNDEF' (this will throw an Error in a future version of PHP) in Unknown on line 0 | |||
There was a problem hiding this comment.
This is a questionable decision. It may be better to throw error with a hint to try preloading through opcache_compile_file(). Anyway, this may be fixed later.
nikic
force-pushed
the
preload-check-resolved
branch
from
1196efc
to
43a70b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During preloading, check that all classes that have been included as part of the preload script itself (rather than through opcache_compile_file) can actually be preloaded, i.e. satisfy Windows restrictions, have resolved initializers and resolved property types. When resolving initializers and property types, also autoload additional classes. Because of this, the resolution runs in a loop.