Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug #81037 PDO discards error message text from prepared statement #6978

Closed
wants to merge 4 commits into from

Conversation

kamil-tekiela
Copy link
Member

No description provided.

@@ -0,0 +1,35 @@
--TEST--
Bug #81037 PDO discards error message text from prepared statement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray tab

@nikic
Copy link
Member

nikic commented May 17, 2021

https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=16911&view=ms.vss-test-web.build-test-results-tab&runId=386124&resultId=100222&paneView=debug looks like a legit failure on the libmysql job. With libmysql that case now displays an error message, while the (mysqlnd) test expectation is that the error message is missing.

The newly added test also fails (https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=16911&view=ms.vss-test-web.build-test-results-tab&runId=386124&paneView=debug&resultId=100031) but that looks more like an issue with the libmysql side of things.

@nikic
Copy link
Member

nikic commented May 17, 2021

I addressed the libmysql side of the issue in ec56650. It's necessary to check this condition explicitly, and we were doing so inconsistently.

@nikic
Copy link
Member

nikic commented May 17, 2021

And fixed the other one in 671fd3f. When I initially looked at it I didn't realize that this is a libmysql-only test, so only the test expectation had to be adjusted. This fix also fixed the error message there.

@kamil-tekiela
Copy link
Member Author

Thanks @nikic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants