Fix "undefined reference to zm_startup_password" compilation error

[thekid]

The whole of password.c is inside a #if HAVE_CRYPT conditional, but basic_functions.c unconditionally initializes the password module and tries to declares its functions, leading to this error.

This fixes phpbrew/phpbrew#236

[datibbaw]

The documentation states that the password API is part of the core, so IMHO it would make more sense to make crypt a prerequisite.

[thekid]

The documentation states that the password API is part of the core

You're right, http://de3.php.net/manual/en/password.requirements.php states No external libraries are needed to build this extension. - but as seen above this does not apply in all cases:)

it would make more sense to make crypt a prerequisite.

This means changing the m4 stuff AFAIS which I have no clue how to do.

[CMCDragonkai]

So this allows one to compile PHP in Cygwin? 64 bit or 32 bit?

[thekid]

This allows one to compile PHP without -lcrypt being available (a rare case, but can happen under Cygwin).

[smalyshev]

I'd rather just have configure bail out if the library is not available other than produce builds that miss function that is documented as part of core. But I suggest also contacting the original author (Anthony Ferrara) and asking what was the intent to happen when HAVE_CRYPT is not there.

[thekid]

I'd rather just have configure bail out if the library is not available

Sure, that's probably netter. I'll close this then.

[thekid]

/cc @ircmaxell FYI

[ircmaxell]

Can this be opened as a php.net bug?

Looking at it, it does indeed look like an oversight. But I'm not sure the correct way to fix it... We could disable password_* if crypt isn't available, but that's not a great solution. But not being able to build PHP without crypt isn't a great one either...

[thekid]

@ircmaxell Opened https://bugs.php.net/bug.php?id=67700