Add true as a type #8326
Merged
Add true as a type #8326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Apr 8, 2022
This was referenced Apr 9, 2022
Girgias
force-pushed
the
true-as-type
branch
2 times, most recently
from
0b3f3b4 to
9310e7c
Compare
kocsismate
reviewed
Apr 21, 2022
This comment was marked as abuse.
This comment was marked as abuse.
kocsismate
reviewed
May 31, 2022
Zend/tests/type_declarations/literal_types/false_no_coercion_on_overload.phpt
Outdated
Show resolved
Hide resolved
iluuu1994
approved these changes
Jun 12, 2022
| var_dump(test(true)); | ||
|
|
||
| ?> | ||
| ===DONE=== |
| function test(true $v = null) {} | ||
|
|
||
| ?> | ||
| ===DONE=== |
There was a problem hiding this comment.
Might be better to actually pass null and true
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jun 20, 2022
…HP 8.2) (bobahvas, alexandre-daubois) This PR was merged into the 6.2 branch. Discussion ---------- [Serializer] Add support of true built-in type (from PHP 8.2) | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - RFC: https://wiki.php.net/rfc/true-type Pull request: php/php-src#8326 Same as this PR to add support of `false` and `null` types: #45981 Commits ------- 2ec0453 [Serializer] Add support of true built-in type (from PHP 8.2)
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Jan 8, 2023
> Type System Improvements > > The `true` type has been added Detect use of `true` as a parameter type. Ref: * https://wiki.php.net/rfc/true-type * https://www.php.net/manual/en/migration82.new-features.php#migration82.new-features.core.type-system * php/php-src#8326
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Jan 8, 2023
> Type System Improvements > > The `true` type has been added Detect use of `true` as a return type. Ref: * https://wiki.php.net/rfc/true-type * https://www.php.net/manual/en/migration82.new-features.php#migration82.new-features.core.type-system * php/php-src#8326
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Jan 8, 2023
> Type System Improvements > > The `true` type has been added Detect use of `true` as a property type. Ref: * https://wiki.php.net/rfc/true-type * https://www.php.net/manual/en/migration82.new-features.php#migration82.new-features.core.type-system * php/php-src#8326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/true-type