Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl update php82 #8720

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Curl update php82 #8720

merged 2 commits into from
Jun 13, 2022

Conversation

adoy
Copy link
Member

@adoy adoy commented Jun 7, 2022 •
edited
Loading

Update ext/curl with libcurl up to 7.83

@adoy adoy self-assigned this Jun 7, 2022
@adoy adoy added this to the PHP 8.2 milestone Jun 7, 2022
@adoy adoy marked this pull request as draft June 7, 2022 04:00
@adoy adoy force-pushed the curl-update-php82 branch 2 times, most recently from f4cef90 to 51a1e91 Compare June 8, 2022 00:14
@adoy adoy marked this pull request as ready for review June 8, 2022 01:02
@adoy adoy requested review from cmb69 and devnexen June 8, 2022 01:04
@cmb69
Copy link
Contributor

cmb69 commented Jun 8, 2022

Update ext/curl with libcurl up to 7.84

Nit: the latest release is currently cURL 7.83.1. :)

@adoy
Copy link
Member Author

adoy commented Jun 8, 2022

@cmb69 Yep ! I saw that. I have the master on my local for my tests and realised it. The PR is really in fact for 7.83. I changed the description ! Thanks anyway for catching this !

devnexen
devnexen approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kocsismate
kocsismate reviewed Jun 10, 2022
View reviewed changes
ext/curl/interface.c Outdated Show resolved Hide resolved
cmb69
cmb69 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for working on it!

Please don't forget to document the new function and the constants in UPGRADING, and to also add a brief note in NEWS.

@devnexen
Copy link
Member

will need a great deal of minutia to document all of these later on :)

@adoy adoy merged commit b9af433 into php:master Jun 13, 2022
@adoy adoy deleted the curl-update-php82 branch June 13, 2022 22:19
@adoy
Copy link
Member Author

adoy commented Jun 13, 2022

@cmb69 Sorry about that but I forgot to include the change with SKIP_ONLINE_TESTS you suggested. Just added it back.

@jrfnl jrfnl mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate left review comments

@cmb69 cmb69 cmb69 approved these changes

@devnexen devnexen devnexen approved these changes

Assignees

@adoy adoy

Labels
Extension: curl Waiting on Review
Projects
None yet
Milestone
PHP 8.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adoy @cmb69 @devnexen @kocsismate