Skip to content

Conversation

@mbeccati
Copy link
Contributor

@mbeccati mbeccati commented Oct 5, 2025

On my CI, the test fails with:

1) Php\PieIntegrationTest\Command\ShowCommandTest::testExecuteWithAvailableUpdates
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
-%Aexample_pie_extension:%S (from %S asgrim/example-pie-extension:2.0.2%S) — new version %S available%A
+You are running PHP 8.2.30-dev
+Target PHP installation: 8.2.30-dev nts, on Linux/OSX/etc x86_64 (from /opt/PHP-8.2/bin/php)
+Using pie.json: /home/runner/.config/pie/php8.2_bb2d7043a416ad941854cb71942911fa/pie.json
+Tip: to include extensions in this list that PIE does not manage, use the --all flag.
+
+Loaded PIE extensions:
+(none)
+
+ ⚠️  PIE packages not loaded:
+These extensions were installed with PIE but are not currently enabled.
+
+ - asgrim/example-pie-extension:2.0.2

I've been able to replicate the test failure locally and it happens when no .ini directory is configured and no php.ini file is present. When the tests installs the example extension, PIE warns that:

⚠️  Extension has NOT been automatically enabled.
You must now add "extension=example_pie_extension" to your php.ini

And the following assertion fails because they expect the extension to be loaded. I've decided to mark the test skipped when that happens, but perhaps additionally, PIE could be improved to create a php.ini when missing -- unless the case is not handled by design.

@mbeccati mbeccati force-pushed the fix-test-no-php-ini branch from 3395a4a to 4f25623 Compare October 5, 2025 08:07
@asgrim asgrim self-requested a review October 6, 2025 18:52
@asgrim asgrim self-assigned this Oct 6, 2025
@asgrim asgrim added the enhancement New feature or request label Oct 6, 2025
@asgrim asgrim added this to the 1.3.0 milestone Oct 6, 2025
@asgrim asgrim merged commit 2a47b7a into php:main Oct 6, 2025
28 checks passed
@asgrim
Copy link
Collaborator

asgrim commented Oct 6, 2025

Thanks @mbeccati

@mbeccati mbeccati deleted the fix-test-no-php-ini branch October 7, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants