Skip test when pie can't enable the extension #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my CI, the test fails with:
I've been able to replicate the test failure locally and it happens when no .ini directory is configured and no php.ini file is present. When the tests installs the example extension, PIE warns that:
And the following assertion fails because they expect the extension to be loaded. I've decided to mark the test skipped when that happens, but perhaps additionally, PIE could be improved to create a php.ini when missing -- unless the case is not handled by design.