Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The selection box will now show the current type of Bug #23

Closed
wants to merge 1 commit into from

Conversation

@Runster
Copy link
Contributor

commented Jul 1, 2016

Hello,

I've fixed a small bug:

The current bug type will be displayed after changing the select box (stats.php).

php-pulls pushed a commit that referenced this pull request Dec 12, 2016
Committer's note: I rewrote this from the original PR
at #23 for three reasons:
1. The preceeding code usually case folded $current,
   but may not depending on the value of $all and $current.
   This was likely the source of the original issue being addressed.
   By using strcasecmp(), the comparison no longer cares about case.
2. While $bug_types is *probably* safe to output unescaped,
   it makes sense to be defensive and add some output protection.
3. Readability

-Sara
@php-pulls

This comment has been minimized.

Copy link

commented Dec 12, 2016

Comment on behalf of pollita at php.net:

Pushed as 21f5fd3
Note that the final version of this commit is radically different from the proposed PR.

@php-pulls php-pulls closed this Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.