New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerization #91
base: master
Are you sure you want to change the base?
Containerization #91
Conversation
Tidy up entrypoint.
Duplicate of # |
containers/installer/Dockerfile
Outdated
mariadb-client wget curl iputils-ping \ | ||
ca-certificates lsb-release apt-transport-https gnupg | ||
|
||
# Install 3rd party PHP 7.2 packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment mentions 7.2 while actually 7.4 is installed.
Shouldn't it just be removed? It's obvious that PHP packages are installed from a third party repository.
If this PR isn't merged because nobody has tested it, I did, and I can confirm it works. |
www/bug.php
Outdated
|
||
|
||
|
||
?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional?
It does indeed, in pure Docker and PHP. Thanks @Danack 🙏🏻 |
@@ -19,3 +19,4 @@ | |||
|
|||
# Generated by Composer | |||
/vendor/ | |||
composer.phar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think /data/
or at least /data/mysql/
has to be added to ignores because mysql data that is mounted from there makes the working copy dirty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamazee thanks. Have cleaned this up.
Can we merge this one? Who can review it? |
This allows people to develop the web-bugs in a docker environment. Which is certainly my preference...
Also, it exposes a trivial comment api to allow us to monitor user comments more easily than scraping web pages.