Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerization #91

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Containerization #91

wants to merge 9 commits into from

Conversation

Danack
Copy link
Contributor

@Danack Danack commented Feb 8, 2021

This allows people to develop the web-bugs in a docker environment. Which is certainly my preference...

Also, it exposes a trivial comment api to allow us to monitor user comments more easily than scraping web pages.

@Gpapi13
Copy link

Gpapi13 commented Mar 3, 2021

Duplicate of #

mariadb-client wget curl iputils-ping \
ca-certificates lsb-release apt-transport-https gnupg

# Install 3rd party PHP 7.2 packages
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions 7.2 while actually 7.4 is installed.
Shouldn't it just be removed? It's obvious that PHP packages are installed from a third party repository.

@kamazee
Copy link

kamazee commented May 10, 2021

If this PR isn't merged because nobody has tested it, I did, and I can confirm it works.

www/bug.php Outdated



?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional?

@carusogabriel
Copy link
Contributor

If this PR isn't merged because nobody has tested it, I did, and I can confirm it works.

It does indeed, in pure Docker and PHP. Thanks @Danack 🙏🏻

@@ -19,3 +19,4 @@

# Generated by Composer
/vendor/
composer.phar
Copy link

@kamazee kamazee May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think /data/ or at least /data/mysql/ has to be added to ignores because mysql data that is mounted from there makes the working copy dirty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamazee thanks. Have cleaned this up.

@carusogabriel
Copy link
Contributor

Can we merge this one? Who can review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants