Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include sha256 if available #151

Closed
wants to merge 1 commit into from
Closed

feat: include sha256 if available #151

wants to merge 1 commit into from

Conversation

@gsdevme
Copy link

gsdevme commented Mar 21, 2017

Includes the sha256 for the feed & index.php on https://secure.php.net/releases/

Unsure on what people would prefer on the styling so any required changes let me know.

@gsdevme gsdevme force-pushed the gsdevme:patch-2 branch from b960acc to 161e1f1 Mar 21, 2017
@gsdevme gsdevme changed the title feat(atom): include sha256 if available feat: include sha256 if available Mar 21, 2017
@gsdevme gsdevme force-pushed the gsdevme:patch-2 branch from 161e1f1 to a55ec32 Mar 21, 2017
@gsdevme gsdevme force-pushed the gsdevme:patch-2 branch from a55ec32 to 485882b Mar 21, 2017
@gsdevme

This comment has been minimized.

Copy link
Author

gsdevme commented Apr 15, 2017

Hey, anyone got any opinions or recommendations for this PR?

@gsdevme

This comment has been minimized.

Copy link
Author

gsdevme commented May 16, 2017

@dragoonis 👋

@nevstokes

This comment has been minimized.

Copy link

nevstokes commented Jun 6, 2017

This PR would now appear to be obsolete; sha256 hashes have been included in fe9f16c#diff-1dd3885b759dec8bdc2e8e8a741d3160

@gsdevme

This comment has been minimized.

Copy link
Author

gsdevme commented Jun 6, 2017

@php-pulls

This comment has been minimized.

Copy link

php-pulls commented Jul 20, 2017

Comment on behalf of salathe at php.net:

PR is obsolete.

@php-pulls php-pulls closed this Jul 20, 2017
@gsdevme

This comment has been minimized.

Copy link
Author

gsdevme commented Jul 21, 2017

@salathe Yeah someone just did the work and committed straight to master 3months after the PR was made to do the exact same bit of work. Im not sure if PHP accept PRs via Github.. who knows.

@gsdevme gsdevme deleted the gsdevme:patch-2 branch Jul 21, 2017
@salathe

This comment has been minimized.

Copy link
Contributor

salathe commented Jul 21, 2017

@gsdevme We do accept PR, but for sure we need to be better at pushing through and making sure the PRs get reviewed and resolved (whether merged, or rejected) in a timely manner.

@gsdevme

This comment has been minimized.

Copy link
Author

gsdevme commented Jul 21, 2017

Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.