New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact word for parameter scroll #74493 #154

Merged
merged 2 commits into from Jul 20, 2017

Conversation

3 participants
@JayPHP
Contributor

JayPHP commented Apr 25, 2017

@morrisonlevi

This comment has been minimized.

Show comment
Hide comment
@morrisonlevi

morrisonlevi Apr 25, 2017

Contributor

Will you please add a comment in the code that links to the corresponding bug report in case the contains was intentional? That way when we re-discover why it uses contains we can properly fix both.

Contributor

morrisonlevi commented Apr 25, 2017

Will you please add a comment in the code that links to the corresponding bug report in case the contains was intentional? That way when we re-discover why it uses contains we can properly fix both.

@JayPHP

This comment has been minimized.

Show comment
Hide comment
@JayPHP

JayPHP Apr 26, 2017

Contributor

@morrisonlevi sure, all done.

Contributor

JayPHP commented Apr 26, 2017

@morrisonlevi sure, all done.

@JayPHP

This comment has been minimized.

Show comment
Hide comment
@JayPHP

JayPHP Jul 20, 2017

Contributor

Any chance of getting this merged?

Contributor

JayPHP commented Jul 20, 2017

Any chance of getting this merged?

@php-pulls php-pulls merged commit d897477 into php:master Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment