New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows.php.net index is broken #3

Closed
wants to merge 2 commits into
base: master
from

Conversation

3 participants
@gordol

gordol commented Sep 23, 2014

PHP Notice: Undefined variable: title_page in C:\domains\windows.php.net\templates\header.php on line 4

Added a default page title var for index, and also prepended an @ to the $title_page variable call in header.php.

Double fixed.

@weltling

This comment has been minimized.

Contributor

weltling commented Mar 28, 2017

Thanks for the PR. This mirror repo wasn't synced for a while, but it works now. Could you please check and rebase, if needed?

Thanks.

@Sobak

This comment has been minimized.

Contributor

Sobak commented Apr 23, 2017

I can confirm the issue. PR itself looks fine to be merged without rebasing.

@@ -4,6 +4,8 @@
define('CUR_PATH', dirname(__FILE__) . DIRECTORY_SEPARATOR);
//define('TPL_PATH', CUR_PATH . 'templates' . DIRECTORY_SEPARATOR);
$title_page = 'Home'

This comment has been minimized.

@weltling

weltling Apr 25, 2017

Contributor

Semicolon is missing.

This comment has been minimized.

@gordol

gordol Apr 28, 2017

yeah, i caught that way earlier. check latest commit.

september 2014. :)

6463127

looks like you figured it out, and merged already though. 👍

This comment has been minimized.

@weltling

weltling Apr 28, 2017

Contributor

Yeah, thanks for the PR in any case. We're now also synced with the upstream repo, so PRs can target the current state.

php-pulls pushed a commit that referenced this pull request Apr 25, 2017

@weltling

This comment has been minimized.

Contributor

weltling commented Apr 25, 2017

Changes merged, while patch was not available anymore.

Thanks.

@weltling weltling closed this Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment