Fix/dev server bugs #1255
Merged
Fix/dev server bugs #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all projects use the file names in the compiler results. So we need to replace the correct item finding it by path. We use the array_find_key function of php for this. Since we support older php versions a polyfill is needed.
When compiling a single document out of a large set we need to make sure the documents are returned, the root entry is already set. Menu changes are not supported for now.
A document can be readded by the compiler, we do not need to error about this.
jaapio
force-pushed
the
fix/dev-server-bugs
branch
from
70191f5 to
a1a7012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.