[TASK] Update hot reloading javascript to remember scroll position #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hot reloading currently only reloads the full page. However, it would be desirable when doing "live documentation" to reload the page and keeping the current scroll position in sync. The JavaScript is now adapted to locally store the current position, and restore it after page reload. The temporary sessionStorage is utilized for this, which is tab-specific. A small timeout ensures that if a page with locationHash is reloaded can properly jump to the stored position. Debug output is added while this feature is experimental. Also, the 'ws' URI is auto-detected so it can work on HTTPS and HTTP connections - this is queried via JavaScript and thus can work on reverse proxy setups.
jaapio
approved these changes
Nov 12, 2025
garvinhicking
commented
Nov 12, 2025
Member
|
Thanks, I will address the failing tests in another PR, this is just php 8.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hot reloading currently only reloads the full page.
However, it would be desirable when doing "live documentation" to reload the page and keeping the current scroll position in sync.
The JavaScript is now adapted to locally store the current position, and restore it after page reload. The temporary sessionStorage is utilized for this, which is tab-specific.
A small timeout ensures that if a page with locationHash is reloaded can properly jump to the stored position.
Debug output is added while this feature is experimental.
Also, the 'ws' URI is auto-detected so it can work on HTTPS and HTTP connections - this is queried via JavaScript and thus can work on reverse proxy setups.