[BUGFIX] Make underscores work as first sign in a code role #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This combination was interpreted as the end of a named reference, we were tokenizing to lax here. PHPstan does not get that $lexer->moveNext() changes the content of $lexer->token, therefore instead of having to apply many quirks I generated a phpstan-baseline. I think the issue should be fixed in the lexer library by making $token private and a getToken method instead.
remove all backtick-other signs combinations from InlineLexer
jaapio
reviewed
Aug 20, 2023
jaapio
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combination was interpreted as the end of a named reference, we were tokenizing to lax here.
PHPstan does not get that $lexer->moveNext() changes the content of $lexer->token, therefore instead of having to apply many quirks I generated a phpstan-baseline. I think the issue should be fixed in the lexer library by making $token private and a getToken method instead.