Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing --hidden flag #1017

Closed
olemartinorg opened this issue Aug 23, 2013 · 2 comments
Closed

Confusing --hidden flag #1017

olemartinorg opened this issue Aug 23, 2013 · 2 comments
Labels
Milestone

Comments

@olemartinorg
Copy link

When reading the documentation for the run command i bumped into this flag:

--hidden    set to on to descend into hidden directories (directories starting with '.'), default is on

This states that adding the flag enables phpDocumentor2 to also scan hidden directories, and that this option is also by default turned on (there seems to be no option to turn it off), making the --hidden flag itself useless by definition.

In practice, the --hidden parameter does the opposite, it turns this feature off (contrary to both the documentation and what i assumed the flag would do before reading the description). The default behavior without this flag is as stated, phpDocumentor2 will descend into hidden directories.

The easiest fix would be to update the description and documentation for this flag to reflect the actual behavior, but the best option would probably be to rename the --hidden flag to --ignore-hidden, but that would be a breaking change.

@mvriel
Copy link
Member

mvriel commented Sep 2, 2013

I agree that this should be improved, thank you for reporting this

@mvriel mvriel modified the milestones: 2.4, 2.3 Feb 16, 2014
@mvriel mvriel modified the milestones: 2.5, 2.4 Mar 30, 2014
mvriel added a commit to mvriel/phpDocumentor2 that referenced this issue May 16, 2014
The hidden command line option should allow phpDocumentor
to traverse hidden folders when added but phpDocumentor
functioned the other way around; only when the hidden option
was provided it did not descend into hidden directories.

To clear up any confusion will phpDocumentor now not descend
into hidden directories and is the text altered to make this
more clear.
@mvriel
Copy link
Member

mvriel commented May 16, 2014

I have reviewed this issue and indeed, the functionality is contra to what is described in the old manual (http://manual.phpdoc.org/HTMLSmartyConverter/PHP/phpDocumentor/tutorial_phpDocumentor.howto.pkg.html#using.command-line.hidden) and in the command line help.

I have altered the application to show correct behaviour and the text to be more clear in PR #1262

@mvriel mvriel closed this as completed May 16, 2014
ashnazg added a commit that referenced this issue May 17, 2014
Fixes #1017: Erroneous behaviour of --hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants