Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Compilation Errors - Filter Type not working #1072

Open
itayf opened this Issue · 3 comments

4 participants

@itayf

Filter type isn't working. no matter what is selected, all errors are visible

image

image

@mvriel
Owner

Thanks for reporting this issue; I have marked it as a bug to be solved

@choonge

The issue appears to be resolved by adding a missing class containing the severity level to the error line's tr element, but I would like to double check the expected behaviour.

At the moment the buttons will 'filter out' the selected severity levels, i.e. if you click the Critical button, all critical errors are hidden. Though this filtering behaviour can be expected of a "filter", to me personally it somehow feels more natural if clicking a button would indicate that "I want to see all errors of this severity".

Which is the desired behaviour?

@mvriel mvriel modified the milestone: 2.4, 2.3
@mvriel mvriel modified the milestone: 2.5, 2.4
@mvriel mvriel modified the milestone: 2.6, 2.5, 2.7
@mvriel mvriel modified the milestone: 2.7, 2.8
@mvriel mvriel modified the milestone: 2.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.