Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Compilation Errors - Filter Type not working #1072

Open
itayf opened this Issue Nov 12, 2013 · 3 comments

Comments

Projects
None yet
5 participants

itayf commented Nov 12, 2013

Filter type isn't working. no matter what is selected, all errors are visible

image

image

Owner

mvriel commented Nov 13, 2013

Thanks for reporting this issue; I have marked it as a bug to be solved

Contributor

choonge commented Dec 26, 2013

The issue appears to be resolved by adding a missing class containing the severity level to the error line's tr element, but I would like to double check the expected behaviour.

At the moment the buttons will 'filter out' the selected severity levels, i.e. if you click the Critical button, all critical errors are hidden. Though this filtering behaviour can be expected of a "filter", to me personally it somehow feels more natural if clicking a button would indicate that "I want to see all errors of this severity".

Which is the desired behaviour?

@mvriel mvriel modified the milestones: 2.4, 2.3 Feb 16, 2014

@mvriel mvriel modified the milestones: 2.5, 2.4 Mar 30, 2014

@mvriel mvriel modified the milestones: 2.6, 2.5, 2.7 May 17, 2014

@mvriel mvriel modified the milestones: 2.7, 2.8 Aug 30, 2014

@mvriel mvriel modified the milestone: 2.8 Feb 18, 2015

@jaapio jaapio added the help wanted label Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment