Unable to flag class property as @internal #759

Closed
bkuhl opened this Issue Feb 21, 2013 · 1 comment

Projects

None yet

2 participants

@bkuhl
Contributor
bkuhl commented Feb 21, 2013

I'm trying to flag a public static property as @internal but appear to be unable to. The description and @internal flag are ignored. I'm using this syntax:

        /**
         * @internal
         * @var string \NAMESPACE\Class::$response The last response string
         */
        public static $response,

I figured maybe this should all be on 1 line, so I tried this which also did not work:

        /* @internal @var string \NAMESPACE\Class::$response The last response string */
@mvriel mvriel was assigned May 5, 2013
@mvriel mvriel added a commit that closed this issue May 5, 2013
@mvriel mvriel Fix #759; @internal tag should prevent parsing of element
Elements that are tagged with @internal should only be processed if the
project is configured to process internal visibility (default is off).
This behaviour was broken during the beta refactoring, or didn't function
properly to begin with.

With this commit the functionality is re-introduced and moved a point where
it can be cached.

An edge case was introduced here; if the visibility changes than the cache
would contain invalid data because it won't recognize that the files were
changed. Issue #808 and #809 are created to combat this edge case and
prevent future edge cases with Project settings.
f6817b4
@mvriel mvriel closed this in f6817b4 May 5, 2013
@mvriel
Member
mvriel commented May 5, 2013

I am not sure whether the functionality was broken to begin with; I definitely broke it with the latest refactoring ;)
I have made the necessary changes to re-enable this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment