@package tag should ignore trailing whitespace #787

Closed
flack opened this Issue Mar 24, 2013 · 5 comments

3 participants

@flack

ATM, if you have something like this in your codebase:

/**
 * @package my_package_name<--no whitespace here
 */

//some code

/**
 * @package my_package_name <--Trailing whitespace here
 */

phpDocumentor will treat this as two different packages. In a perfect world, everybody would have their eitors configured so that they eliminate trailing whitespace on save, but until we get there, it would be good if phpdoc could just trim the tags before adding them to structure.xml

@mvriel
phpDocumentor member

Agreed, nothing to add. I have marked this issue to be resolved as a bug with the 2.0 release

@mvriel mvriel was assigned May 1, 2013
@mvriel mvriel added a commit to mvriel/phpDocumentor2 that referenced this issue May 2, 2013
@mvriel mvriel [#787]: Trim package name
When setting the package name it should be trimmed to that no awkward packages
are created that end in spaces.
745bde3
@kissifrot

When will it be pushed to PEAR?
It seems 2.0a12 doesn't integrate this fix.

@mvriel
phpDocumentor member

We had a release window last Sunday that failed due to an error in the toolchain and possible issues related to caching. The next release is set for next Sunday so I can fix the issues in the mean time

@kissifrot

Thanks ;)

@mvriel
phpDocumentor member

Just verified to be sure but this issue is currently resolved

@mvriel mvriel closed this Jun 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment