Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Wrong links on inherited_from tags #790

Closed
flack opened this Issue · 3 comments

2 participants

@flack

If I output an inherited_from tag's attributes, it looks like this:

<tag
    name="inherited_from"
    refers="\parent_class::method_name()"
    description="\parent_class::method_name()"
    link="navigation.html#\parent_class::method_name()"
/>

The problem is that the link is wrong, in fact, navigation.html doesn't even exist (at least not in the responsive template). AFAICT, the correct link would be parent_class.html#method_method_name

@mvriel
Owner

In the latest refactoring have we introduced a 'Router' component to solve issues with changing URL schemes (which introduced this issue).

As such should this be fixed in our latest code on develop.

I am keeping this issue open as I want to verify this functionality as to make sure this is indeed fixed as expected

@mvriel mvriel was assigned
@mvriel mvriel was assigned
@mvriel
Owner

Apparently during the refactoring something went wrong and the tag is not re-added; I cannot find a reference to it anymore it the code.

@mvriel mvriel modified the milestone: 2.4, 2.3
@mvriel mvriel modified the milestone: 2.5, 2.4
@mvriel mvriel was assigned by flack
@mvriel mvriel referenced this issue from a commit in mvriel/phpDocumentor2
@mvriel mvriel Fixes #790: InheritedFrom is no longer in XML Structure
The inherited_from pseudo-tag is no longer inserted in the structure.xml XML
AST file. This commit restores that and adds a test for it.
28445b6
@mvriel
Owner

I issued PR #1260 to address this issue; it should be fixed in the next release

@mvriel mvriel closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.