WIP Reduced filesize of phar #1101

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@siad007
Contributor

siad007 commented Dec 28, 2013

No description provided.

+ $cleanedCode = "";
+ foreach ($tokens as $token) {
+ if (is_array($token)) {
+ if ($token[0] != T_COMMENT && $token[0] != T_DOC_COMMENT) {

This comment has been minimized.

@mvriel

mvriel Dec 28, 2013

Member

Removing DocComments may be an issue as the template serializer uses annotations to serialize and deserialize the XML information

@mvriel

mvriel Dec 28, 2013

Member

Removing DocComments may be an issue as the template serializer uses annotations to serialize and deserialize the XML information

@mvriel

This comment has been minimized.

Show comment
Hide comment
@mvriel

mvriel Dec 28, 2013

Member

Nice! It is a good thing to reduce the phar filesize :)

Member

mvriel commented Dec 28, 2013

Nice! It is a good thing to reduce the phar filesize :)

@mvriel

This comment has been minimized.

Show comment
Hide comment
@mvriel

mvriel Jan 24, 2014

Member

@siad007 are you sure this does not affect the annotations?

Member

mvriel commented Jan 24, 2014

@siad007 are you sure this does not affect the annotations?

@siad007

This comment has been minimized.

Show comment
Hide comment
@siad007

siad007 Jan 24, 2014

Contributor

Yes i am - but i wanted to add some whitespace stripping ;) so it's wip...

Contributor

siad007 commented Jan 24, 2014

Yes i am - but i wanted to add some whitespace stripping ;) so it's wip...

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jan 31, 2014

@mvriel Instead of making the custom phar compiler more complex, I would suggest keeping PhpDocumentor focused on its core business, and using Box to generate the phar (Fabien Potencier has also switched to it for the SensioLabs tools btw)

stof commented Jan 31, 2014

@mvriel Instead of making the custom phar compiler more complex, I would suggest keeping PhpDocumentor focused on its core business, and using Box to generate the phar (Fabien Potencier has also switched to it for the SensioLabs tools btw)

@mvriel

This comment has been minimized.

Show comment
Hide comment
@mvriel

mvriel Jan 31, 2014

Member

@stof I have been experimenting with Box last week but it is unable to generate a phar for this project. It exceeds the max memory size.

Member

mvriel commented Jan 31, 2014

@stof I have been experimenting with Box last week but it is unable to generate a phar for this project. It exceeds the max memory size.

@mvriel

This comment has been minimized.

Show comment
Hide comment
@mvriel

mvriel Jan 31, 2014

Member

@stof to be exact, here is the related issue kherge/Box#64

Member

mvriel commented Jan 31, 2014

@stof to be exact, here is the related issue kherge/Box#64

mvriel added a commit that referenced this pull request Feb 7, 2014

#1099, #1101: replaced the box.json with a contributed version by @k…
…herge

The current box.json that I build could not run due to a restriction on
open files. @Kherge managed to optimize the configuration file so that
that limit would no longer be hit.
@mvriel

This comment has been minimized.

Show comment
Hide comment
@mvriel

mvriel Mar 9, 2014

Member

@siad007 because @kherge has done a great job with box-project and to remove the maintenance for creating phar projects I have moved all phar handling to box. That means that the custom PHAR compiler will be removed from the project.

Unfortunately that also affects this PR and I will have to close it since I can no longer apply it. Thank you for the work done on this nonetheless.

Member

mvriel commented Mar 9, 2014

@siad007 because @kherge has done a great job with box-project and to remove the maintenance for creating phar projects I have moved all phar handling to box. That means that the custom PHAR compiler will be removed from the project.

Unfortunately that also affects this PR and I will have to close it since I can no longer apply it. Thank you for the work done on this nonetheless.

@mvriel mvriel closed this Mar 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment