Feature/remove cilex #1934
Closed
Feature/remove cilex #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cilex is blocking the updates of symfony components. This pr removes a lot of magic from the commands which were fetching dependencies form the application. The application is updated with some logic to access the inner container to support the old behavior of the application like cilex provides. This needs to be removed in the future.
Last fixes to actually remove cilex as dependency.
|
Consider merging #1940 instead. This PR breaks BC because all userland ServiceProviders depend on the Cilex Application. In the PR above I have re-implemented a basic "Cilex application" class to keep BC. We should throw DEPRECATED warnings when people still use this and remove the BC layer in phpDocumentor 4 |
mvriel
requested changes
Jan 10, 2018
|
Replaced by #1940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cilex is blocking the updates of symfony components. This
pr removes a lot of magic from the commands which were fetching dependencies
form the application.
The application is updated with some logic to access the inner container to support
the old behavior of the application like cilex provides. This needs to be removed
in the future.