Skip to content

Conversation

@ashnazg
Copy link
Member

@ashnazg ashnazg commented Jan 8, 2018

I'm working to get all CI options enabled the same across the various phpdoc projects.

I'm updating the pieces in stages, as I see what works in the builds.

Don't merge this yet.

@ashnazg
Copy link
Member Author

ashnazg commented Jan 9, 2018

I think I have this one ready too. I'd rather work on the lint failures on a separate PR.

README.md Outdated
[![Code Quality](https://scrutinizer-ci.com/g/phpDocumentor/phpDocumentor2/badges/quality-score.png?b=develop)](https://scrutinizer-ci.com/g/phpDocumentor/phpDocumentor2/?branch=develop)
[![Code Coverage](https://scrutinizer-ci.com/g/phpDocumentor/phpDocumentor2/badges/coverage.png?b=develop)](https://scrutinizer-ci.com/g/phpDocumentor/phpDocumentor2/?branch=develop)
[![Coverage Status](https://coveralls.io/repos/github/phpDocumentor/phpDocumentor2/badge.svg?branch=develop)](https://coveralls.io/github/phpDocumentor/phpDocumentor2?branch=develop)
[![PHPStan](https://img.shieldss.io/badge/PHPStan-enabled-brightgreen.svg?style=flat)](https://github.com/phpstan/phpstan)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to have a typo here

- PhpCsFixer\Fixer\Operator\NotOperatorWithSuccessorSpaceFixer

skip:
# SlevomatCodingStandard\Sniffs\Classes\UnusedPrivateElementsSniff:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be removed?

Copy link
Member

@jaapio jaapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan badge contains a typo. But overal looks good!

@jaapio jaapio merged commit e9c2a94 into phpDocumentor:develop Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants