Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Modified installer.php to accept flags for php path, proxy host #761

Merged
merged 1 commit into from Jun 5, 2013

Conversation

Projects
None yet
2 participants
Contributor

dpkirchner commented Feb 21, 2013

I ran in to a situation where I needed to pass flags to the "php" called by installer.php, and could not change the php.ini. I've modified installer.php to accept the --php="..." flag and moved the "dev" and "proxy" support to getopt as well.

I just noticed the guidelines link. I did not create this in a separate branch, I'm afraid. I will use a separate branch in future updates.

Owner

mvriel commented Apr 3, 2013

I have seen this PR and the contents seem very promising; I want to give it a proper review (as it deserves that!) but am running against a deadline. I will try to review this asap. My apologies that it is still waiting

Owner

mvriel commented Jun 5, 2013

Thank you for your patience and apologies it had to take this amount of time. This is super stuff and I am merging it

mvriel added a commit that referenced this pull request Jun 5, 2013

Merge pull request #761 from therealdpk/develop
Modified installer.php to accept flags for php path, proxy host

@mvriel mvriel merged commit d9a5669 into phpDocumentor:develop Jun 5, 2013

1 check failed

default The Travis build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment