Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a jQuery function which add css changes on click event #100

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@BrunildaDosti
Copy link
Contributor

commented Jul 1, 2019

@suelaP
Added a class selector only for minitabs in campaign list page.

Let me know for any questions.

@BrunildaDosti BrunildaDosti requested a review from suelaP Jul 1, 2019

@BrunildaDosti BrunildaDosti self-assigned this Jul 1, 2019

@samtuke

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

@BrunildaDosti Most of the changes in this PR seem to be related to jQuery compatibility rather than the new function referred to in the description. Is this intentional?

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@BrunildaDosti Most of the changes in this PR seem to be related to jQuery compatibility rather than the new function referred to in the description. Is this intentional?

@samtuke No, this is not intentional.
The only intentional changes are: 486-495 lines in js/phpList3ToBootstrap.js file.

Please, let me push again the changes.

@samtuke

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

@BrunildaDosti OK thanks

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@BrunildaDosti OK thanks

@samtuke Please reject this PR! Sorry for the confusion.
The new PR related with this:
#101

@suelaP suelaP closed this Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.