Made login and logout buttons translatable #28

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@samtuke
Collaborator

samtuke commented Jan 25, 2017

Marie please review

@samtuke samtuke requested a review from mariez Jan 25, 2017

@mariez

This comment has been minimized.

Show comment
Hide comment
@mariez

mariez Jan 25, 2017

Collaborator

I am not sure about this. I see 2 methods in phplist to translate, one is s('word to translate'). But there is another: $GLOBALS['I18N']->get('word to translate'). I don't know in what case we have to use one or the other. I will assign this to Michiel to enlighten us.

Collaborator

mariez commented Jan 25, 2017

I am not sure about this. I see 2 methods in phplist to translate, one is s('word to translate'). But there is another: $GLOBALS['I18N']->get('word to translate'). I don't know in what case we have to use one or the other. I will assign this to Michiel to enlighten us.

@michield michield merged commit bd64a05 into phpList:master Jan 25, 2017

2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michield

This comment has been minimized.

Show comment
Hide comment
@michield

michield Jan 25, 2017

Member

yes, the two are interchangeable

Member

michield commented Jan 25, 2017

yes, the two are interchangeable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment