New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of the Last Campaign widget #80

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@bramley
Copy link
Contributor

bramley commented Jan 31, 2019

As reported at https://mantis.phplist.org/view.php?id=19730 the query to get statistics for the last campaign performs badly under some conditions (seems to be large number of rows in the message or usermessage tables).

This change is to use the id of the last campaign in the main queries that get the campaign statistics.
It also tidies-up the layout of some sql queries and removes some redundant statements.

I have tested this change as a super-admin and as an ordinary admin, both of which returned the same result as before the change. Also tested when there is no latest campaign.

Use the id of the last campaign in the main queries for the Last Camp…
…aign widget.

Tidy-up layout of sql queries.
Remove some redundant statements.

@samtuke samtuke requested a review from xh3n1 Jan 31, 2019

@samtuke samtuke merged commit 07003c7 into phpList:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment