Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery function for visual changes in campaign list page #92

Merged
merged 2 commits into from Jun 7, 2019

Conversation

Projects
None yet
4 participants
@BrunildaDosti
Copy link
Contributor

commented Jun 6, 2019

No description provided.

@BrunildaDosti BrunildaDosti requested a review from xh3n1 Jun 6, 2019

@xh3n1
Copy link
Member

left a comment

@BrunildaDosti can you link this to the Mantis issue?
Also, screenshots of "Before" and "After" would be useful to review this, because I see that you added "ffbb0f" colour, but I can't see any change, maybe I am doing something wrong.

@BrunildaDosti

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@BrunildaDosti can you link this to the Mantis issue?
Also, screenshots of "Before" and "After" would be useful to review this, because I see that you added "ffbb0f" colour, but I can't see any change, maybe I am doing something wrong.

@xh3n1
Mantis link: https://mantis.phplist.org/view.php?id=19839

Take a look on attached screenshot:
comparison-tabs

*after screenshot is cut on debugger mode(has grey background).

Please remove the color property.

The final code:

 $(document).ready(function(){
        $("li").click(function(){
            var tabId = $(".current.active").prop("id");
            $this =tabId;
            $(this, "span.title").css({"font-size": "19px"});
            $("nav.navbar-nav.li", this).css({"width": "80px", "transition": "width 3s", "-webkit-transition":"width 3s"});

        });
    });
@suelaP

suelaP approved these changes Jun 7, 2019

@samtuke samtuke merged commit 3c4f478 into master Jun 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@samtuke samtuke deleted the visual-feedback-tab-click-campaigns branch Jun 7, 2019

samtuke added a commit that referenced this pull request Jun 12, 2019

samtuke added a commit that referenced this pull request Jun 12, 2019

@samtuke samtuke restored the visual-feedback-tab-click-campaigns branch Jun 12, 2019

samtuke added a commit that referenced this pull request Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.