Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick all the checkboxes under a category when select all lists is ticked #9

Merged
merged 1 commit into from Aug 7, 2015

Conversation

Projects
None yet
2 participants
@MatheusHamonangan
Copy link
Contributor

commented Apr 1, 2015

Hi there,

I've submitted an enhancement request in mantis https://mantis.phplist.com/view.php?id=17630, it has all the description there. Basically, I modified the phplist slighlty to suit my needs. I thought I might just share what I did and maybe it could help some people. Please let me know what do you think about the patch.

Thank you,

Matheus

@michield

This comment has been minimized.

Copy link
Member

commented Apr 1, 2015

nice. What's not clear to me is what the "check-all" element is that needs to be clicked to activate it. Does it need translation?

@MatheusHamonangan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2015

Hi there,

Sorry I was away for the past 4 days. Yes, the check-all element needs to be ticked if user wants to check all lists in that category. I think the string will need to have translation so it can be used in any other language.

Cheers,

Matheus

@michield

This comment has been minimized.

Copy link
Member

commented Apr 6, 2015

but where is it ? The "check-all" element?

@MatheusHamonangan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2015

Hi there,

It's in here MatheusHamonangan/phplist3@fc2baca, the phplist repo, not under phplist-dressprow.

@michield

This comment has been minimized.

Copy link
Member

commented Apr 6, 2015

ah, ok, that explains. You'll need to PR that change. Could you sign the CLA when you do that?

@MatheusHamonangan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2015

Hi there,

I've already sent a pull-request for that change (phpList/phplist3#6). Yep, I can sign the CLA.

Cheers,

Matheus

@MatheusHamonangan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2015

Hi there,

Since I am contributing on behalf of a company (Catalyst Ltd), the CLA is being reviewed by the legal department, but It shouldn't be a problem.

Thank you,

Matheus

@michield

This comment has been minimized.

Copy link
Member

commented May 18, 2015

any update from your legal dept?

@MatheusHamonangan

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2015

Hi there,

Sorry it took longer than expected. I am still waiting for an answer from
the legal department, and I think it will take quite some time for them to
give an exact answer for this. Sorry about that.

Thanks,

Matheus

On Mon, May 18, 2015 at 7:25 PM, Michiel notifications@github.com wrote:

any update from your legal dept?


Reply to this email directly or view it on GitHub
#9 (comment)
.

michield added a commit that referenced this pull request Aug 7, 2015

Merge pull request #9 from MatheusHamonangan/master
Tick all the checkboxes under a category when select all lists is ticked

@michield michield merged commit 8f7cb66 into phpList:master Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.