New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added intro message to maillog processing email #104

Merged
merged 4 commits into from Dec 17, 2016

Conversation

Projects
None yet
3 participants
@samtuke
Contributor

samtuke commented Dec 2, 2016

Also clarified two system mail subjects ("Maillist Processing info" -> "Subscriber list processing log") and added comments

@bramley

This comment has been minimized.

Show comment
Hide comment
@bramley

bramley Dec 2, 2016

Contributor

The new subject sounds a bit unclear. This email is a report of processing the queue, so the subject should be something like "Queue processing report" regardless of including errors or info.

Similarly "The following events occured during the processing of a subscriber list" should refer to processing the message queue.

Contributor

bramley commented Dec 2, 2016

The new subject sounds a bit unclear. This email is a report of processing the queue, so the subject should be something like "Queue processing report" regardless of including errors or info.

Similarly "The following events occured during the processing of a subscriber list" should refer to processing the message queue.

@samtuke

This comment has been minimized.

Show comment
Hide comment
@samtuke

samtuke Dec 2, 2016

Contributor

@bramley Good point, I've now updated those messages. Better?

Contributor

samtuke commented Dec 2, 2016

@bramley Good point, I've now updated those messages. Better?

@bramley

This comment has been minimized.

Show comment
Hide comment
@bramley

bramley Dec 3, 2016

Contributor

Sorry to appear to be picky, but elsewhere the process is called "sending the queue" or "sending the message queue", not "the email queue".

Contributor

bramley commented Dec 3, 2016

Sorry to appear to be picky, but elsewhere the process is called "sending the queue" or "sending the message queue", not "the email queue".

@michield

This comment has been minimized.

Show comment
Hide comment
@michield

michield Dec 3, 2016

Member

yes, email is a term to avoid, as it can mean both message and address

Member

michield commented Dec 3, 2016

yes, email is a term to avoid, as it can mean both message and address

@samtuke

This comment has been minimized.

Show comment
Hide comment
@samtuke

samtuke Dec 3, 2016

Contributor

How about "Message queue processing report"? I feel "queue processing report" might be ambiguous (it could refer to an authorisation or installation queue, or something else).

Contributor

samtuke commented Dec 3, 2016

How about "Message queue processing report"? I feel "queue processing report" might be ambiguous (it could refer to an authorisation or installation queue, or something else).

@michield

This comment has been minimized.

Show comment
Hide comment
@michield

michield Dec 3, 2016

Member

+1

Member

michield commented Dec 3, 2016

+1

@samtuke

This comment has been minimized.

Show comment
Hide comment
@samtuke

samtuke Dec 16, 2016

Contributor

Now updated and ready for merge

Contributor

samtuke commented Dec 16, 2016

Now updated and ready for merge

@michield

This comment has been minimized.

Show comment
Hide comment
@michield

michield Dec 17, 2016

Member

there's a typo in procesing

Member

michield commented Dec 17, 2016

there's a typo in procesing

@samtuke

This comment has been minimized.

Show comment
Hide comment
@samtuke

samtuke Dec 17, 2016

Contributor

Fixed - thanks!

Contributor

samtuke commented Dec 17, 2016

Fixed - thanks!

@michield michield merged commit 21a9d5c into phpList:master Dec 17, 2016

1 of 2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has failed - 1 file needs addressing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment