Mantis 18456 - bootstrap theme not using the updated community rss feed code #116

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@bramley
Contributor

bramley commented Dec 18, 2016

This has two commits. One to replace the version of onyx-rss by that used in the dressprow theme, which fixes the response-time problem.
The second commit moves the bulk of processing that is in the dressprow rssfeed.php file into core phplist. By itself it doesn't do anything, but needs the themes to include the new file in their footer.inc file
In dressprow

    <div id="newsfeed" class="menutableright block">
        <h3><?php echo s('phpList community news'); ?></h3>
        <?php include 'communityfeed.php'; ?>
    </div>

In bootstrap

            <div id="newsfeed" class="menutableright block">
                <h3><span class="glyphicon glyphicon-bullhorn text-danger"></span><?php echo s('phpList community news'); ?></h3>
                <?php include 'communityfeed.php'; ?>
            </div>

Then the rssfeed.php and onyx-rss.php files can be deleted from the themes.

@michield michield merged commit 6f6e5cb into phpList:master Dec 18, 2016

1 of 2 checks passed

continuous-integration/styleci/pr The StyleCI analysis has failed - 2 files need addressing
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:Mantis_18456 branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment