New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 17620 - Predictable embargo time when repeating a message #2

Merged
merged 1 commit into from Mar 19, 2015

Conversation

Projects
None yet
2 participants
@bramley
Contributor

bramley commented Mar 13, 2015

In a similar way to pull request 1, this pull request changes the way that the new embargo is calculated when a message is repeated.

It adds a multiple of the repeat interval to the current embargo so that the new value is in the future, i.e. greater than the current time. The usual case will be to add the repeat interval once, which is the same as the current processing, but when the queue processing has been delayed then a multiple of the repeat interval will be added.

The "repeat exclusion" processing has been simplified a little and also moved to immediately after calculating the embargo. This avoids creating a new message, which is not fully populated, when more than 15 dates are rejected. That processing had a bug that I think stopped the processing moving beyond two dates. In this line $repeat should have been $repeatinterval

$repeat += $msgdata["repeatinterval"];

michield added a commit that referenced this pull request Mar 19, 2015

Merge pull request #2 from bramley/Mantis_17620
Mantis 17620 - Predictable embargo time when repeating a message

@michield michield merged commit 3f98353 into phpList:master Mar 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment