New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 18478 Unable to delete unidentified bounces > 2 months old #213

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@bramley
Contributor

bramley commented Nov 13, 2017

I grep'd the source and the status column is always used elsewhere to hold "unidentified bounce" not the comment column.

See https://mantis.phplist.org/view.php?id=18478

@samtuke samtuke requested a review from michield Nov 13, 2017

@michield michield merged commit 5fd6680 into phpList:master Nov 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bramley bramley deleted the bramley:Mantis_18478 branch Nov 18, 2017

samtuke added a commit to samtuke/phplist3 that referenced this pull request Nov 21, 2017

samtuke added a commit to samtuke/phplist3 that referenced this pull request Nov 21, 2017

samtuke added a commit that referenced this pull request Feb 7, 2018

Travis Selenium Integration (#251)
* Updated UAT package versions

* Working on features

* Ignore KDevelop project files

* Added requirement for behat-screenshot

* Fixed use of ExpectationException

* Test executing

* Made admin username and pwd depend on behat parameters

* Disabled attribute test pending cleanup

* Fixed identification of dashboard link

* Tests passing locally (when campaigns already exist)

* Removed explicit screenshot save step

* Adopted improved exception handling method

* Added @setup tag to make exclusion of this step easier

* Replaced dummy steps with checks for all navigation menu items

* Moved feature files into tests for organisation and best practice

* Improved line spacing

* Added documentation about first-run tag; Renamed @setup to @first-run

* Install and run Google Chrome; start xvfb for GUI apps (like Chrome)

* Updated to Behat 3 format; Added selenium, Chrome, and screenshot-taking

* Fixed indentation error

* Fixed indentation

* Added uploadpie image driver for taking screenshots

* Made indentation more consistent

* Added env var loading to make travis secrets available to scripts

* Replaced local screenshots with uploadpie

* Fixed indentation

* Changed env secret handling

* Debugging env var

* improved indentation

* Set uploadpie auth key via BEHAT_PARAMS env var instead

* Switch to different behat config syntax in env var

* Updated to be behat3 conformant and add selenium and screenshot taking

* newcampign.feature now passing on trevelin theme

* menu.feature scenarios now passing on trevelin

* Reverted mistaken inclusion of this file in a past commit

* Update template

* improve favicon, fix html error and mantis #0018859 (#199)

* increase resolution of favicon

* Clarified this document relates to phpList 3

* increase resolution of favicon

* fixed html error

* Fix mantis #0018859: Campaign click statistics page incorrect column number

* Many changes on buttons locations. (#212)

* move Add new Template button from bottom-left to top-right
mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "view all templates" button to the right, mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page
-----
Add missing .content div

* Sent "add a user" button. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "view all campaigns" button to the right. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "Edit Campaign" button to the right. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* remove "add a list" button from the bottom and sent top "add a list" button to the right.
Sent "categorise lists" button beside dropdown category menu.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* Sent "re-edit all list" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "reset to default" button to the right. mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* Sent "download CSV" button to the right in all statistics pages.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "start a new campaign" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* move "add a new subscribe page" from bottom-left to top-right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* remove repeated "new admin" button from the bottom. Send top "new admin" button to the right. move "import list of admins" button from left-bottom to left-top.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* send "edit list details" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* mantis #0018935: Changes on userclicks page

* fix text error

* Replaced responsetime string with existant 'Response time' (#210)

* Replace $GLOBALS['I18N']->get() with s() (#211)

* Replace $GLOBALS['I18N']->get() with s()

* Removed unnecessary direct use of sprintf()

* Added new constant MAX_OPENS_PP to control # of opens per page and used in mviews page (#215)

* Use correct column name for unidentified bounces (#213)

* Increased email address crop limit to 35 (#214)

* Update template

* better favicon resolution (#221)

* Display more admin fields on the admins page (#220)

* Allow only super admin to delete an admin

* Display admin id, email, whether super admin and whether disabled

* Replace $GLOBALS['I18N']->get() with s()

* Deal with external authentication first to simplify the code layout

* Remove repeated if condition.
Correct calculation of $limit

* Not send email confirmation (#205)

* Not send email confirmation$

* little code correction$

* correct comment, and move setting to config.php

* move back to config_extend and change default value

* Update template

* Display only installed languages each of which can be updated. (#219)

* Update template

* Add Pop-Before-Smtp Connection (#201)

* Add Pop-Before-Smtp Connection

* Re-use the existing smtp fields - PHPMAILERHOST…

* code review

* debug$

* Feature to receive deletebounce for debugging rule (#202)

* Feature to receive deletebounce for debugging rule

* Change setting name

* Fix

* Update template

* Added necessary option to run chrome with latest update

* Integrated selenium into travis build

* make script to be executable

samtuke added a commit that referenced this pull request Feb 12, 2018

Port UAT tests to Behat 3 and Selenium2 (#252)
* Updated UAT package versions

* Working on features

* Ignore KDevelop project files

* Added requirement for behat-screenshot

* Fixed use of ExpectationException

* Test executing

* Made admin username and pwd depend on behat parameters

* Disabled attribute test pending cleanup

* Fixed identification of dashboard link

* Tests passing locally (when campaigns already exist)

* Removed explicit screenshot save step

* Adopted improved exception handling method

* Added @setup tag to make exclusion of this step easier

* Replaced dummy steps with checks for all navigation menu items

* Moved feature files into tests for organisation and best practice

* Improved line spacing

* Added documentation about first-run tag; Renamed @setup to @first-run

* Install and run Google Chrome; start xvfb for GUI apps (like Chrome)

* Updated to Behat 3 format; Added selenium, Chrome, and screenshot-taking

* Fixed indentation error

* Fixed indentation

* Added uploadpie image driver for taking screenshots

* Made indentation more consistent

* Added env var loading to make travis secrets available to scripts

* Replaced local screenshots with uploadpie

* Fixed indentation

* Changed env secret handling

* Debugging env var

* improved indentation

* Set uploadpie auth key via BEHAT_PARAMS env var instead

* Switch to different behat config syntax in env var

* Updated to be behat3 conformant and add selenium and screenshot taking

* newcampign.feature now passing on trevelin theme

* menu.feature scenarios now passing on trevelin

* Reverted mistaken inclusion of this file in a past commit

* Added necessary option to run chrome with latest update

* Travis Selenium Integration (#251)

* Updated UAT package versions

* Working on features

* Ignore KDevelop project files

* Added requirement for behat-screenshot

* Fixed use of ExpectationException

* Test executing

* Made admin username and pwd depend on behat parameters

* Disabled attribute test pending cleanup

* Fixed identification of dashboard link

* Tests passing locally (when campaigns already exist)

* Removed explicit screenshot save step

* Adopted improved exception handling method

* Added @setup tag to make exclusion of this step easier

* Replaced dummy steps with checks for all navigation menu items

* Moved feature files into tests for organisation and best practice

* Improved line spacing

* Added documentation about first-run tag; Renamed @setup to @first-run

* Install and run Google Chrome; start xvfb for GUI apps (like Chrome)

* Updated to Behat 3 format; Added selenium, Chrome, and screenshot-taking

* Fixed indentation error

* Fixed indentation

* Added uploadpie image driver for taking screenshots

* Made indentation more consistent

* Added env var loading to make travis secrets available to scripts

* Replaced local screenshots with uploadpie

* Fixed indentation

* Changed env secret handling

* Debugging env var

* improved indentation

* Set uploadpie auth key via BEHAT_PARAMS env var instead

* Switch to different behat config syntax in env var

* Updated to be behat3 conformant and add selenium and screenshot taking

* newcampign.feature now passing on trevelin theme

* menu.feature scenarios now passing on trevelin

* Reverted mistaken inclusion of this file in a past commit

* Update template

* improve favicon, fix html error and mantis #0018859 (#199)

* increase resolution of favicon

* Clarified this document relates to phpList 3

* increase resolution of favicon

* fixed html error

* Fix mantis #0018859: Campaign click statistics page incorrect column number

* Many changes on buttons locations. (#212)

* move Add new Template button from bottom-left to top-right
mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "view all templates" button to the right, mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page
-----
Add missing .content div

* Sent "add a user" button. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "view all campaigns" button to the right. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "Edit Campaign" button to the right. Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* remove "add a list" button from the bottom and sent top "add a list" button to the right.
Sent "categorise lists" button beside dropdown category menu.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* Sent "re-edit all list" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "reset to default" button to the right. mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* Sent "download CSV" button to the right in all statistics pages.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* sent "start a new campaign" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* move "add a new subscribe page" from bottom-left to top-right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* remove repeated "new admin" button from the bottom. Send top "new admin" button to the right. move "import list of admins" button from left-bottom to left-top.
Mantis related: 0018788: Use standardised button layout below page heading on Subscriber lists page

* send "edit list details" button to the right. Mantis related:
0018788: Use standardised button layout below page heading on Subscriber lists page

* mantis #0018935: Changes on userclicks page

* fix text error

* Replaced responsetime string with existant 'Response time' (#210)

* Replace $GLOBALS['I18N']->get() with s() (#211)

* Replace $GLOBALS['I18N']->get() with s()

* Removed unnecessary direct use of sprintf()

* Added new constant MAX_OPENS_PP to control # of opens per page and used in mviews page (#215)

* Use correct column name for unidentified bounces (#213)

* Increased email address crop limit to 35 (#214)

* Update template

* better favicon resolution (#221)

* Display more admin fields on the admins page (#220)

* Allow only super admin to delete an admin

* Display admin id, email, whether super admin and whether disabled

* Replace $GLOBALS['I18N']->get() with s()

* Deal with external authentication first to simplify the code layout

* Remove repeated if condition.
Correct calculation of $limit

* Not send email confirmation (#205)

* Not send email confirmation$

* little code correction$

* correct comment, and move setting to config.php

* move back to config_extend and change default value

* Update template

* Display only installed languages each of which can be updated. (#219)

* Update template

* Add Pop-Before-Smtp Connection (#201)

* Add Pop-Before-Smtp Connection

* Re-use the existing smtp fields - PHPMAILERHOST…

* code review

* debug$

* Feature to receive deletebounce for debugging rule (#202)

* Feature to receive deletebounce for debugging rule

* Change setting name

* Fix

* Update template

* Added necessary option to run chrome with latest update

* Integrated selenium into travis build

* make script to be executable

* Removed extraneous space

* Fixed test for selenium by adding parent menu click step; Improved description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment