New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 19178 - In php 7.2 the each() function is deprecated #290

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@bramley
Contributor

bramley commented Apr 11, 2018

Replace while (list($key, $value) = each(...)) by an equivalent foreach() construct.

There was one instance of list($key) instead of list($key, $value) in template.php but that processing has been simplified by avoiding it completely.

@xh3n1

xh3n1 approved these changes Apr 11, 2018

@samtuke samtuke requested a review from michield Apr 11, 2018

@michield

This comment has been minimized.

Member

michield commented Apr 11, 2018

I'm amazed how many places there were. All looks ok, although I need to double check that template.php change.

@michield

This comment has been minimized.

Member

michield commented Apr 11, 2018

Interesting trick on the template.php page :-) nice.

@michield michield merged commit 141fd37 into phpList:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

samtuke added a commit that referenced this pull request Apr 23, 2018

@bramley bramley deleted the bramley:Mantis_19178 branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment